Conversation
9514311 to
8275f9a
Compare
danmoseley
left a comment
There was a problem hiding this comment.
LGTM. I diffed every file. thanks for doing this!
| @@ -21,7 +21,7 @@ namespace System | |||
| // message describing what was wrong and which parameter is incorrect. | |||
| // | |||
| [Serializable] | |||
| public class ArgumentException : SystemException, ISerializable | |||
There was a problem hiding this comment.
removed because it's on the baseclass alreayd?
There was a problem hiding this comment.
Yes - it is not necessary. It was removed in CoreRT, and it is consistent with most other CoreLib exception types.
| else | ||
| { | ||
| // do any desired fixups to classname here. | ||
| return SR.Format(SR.MissingField_Name, (Signature != null ? FormatSignature(Signature) + " " : "") + ClassName + "." + MemberName); |
There was a problem hiding this comment.
Looks like you fixed a bug in the ordering
There was a problem hiding this comment.
Hmm, this is implemented differently between CoreCLR and CoreRT. Not sure which side is right. I will exclude this file from this batch.
| @@ -2,7 +2,6 @@ | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
| // See the LICENSE file in the project root for more information. | |||
|
|
|||
| // | |||
There was a problem hiding this comment.
nit, you didn't delete the purpose comment in this one.
There was a problem hiding this comment.
I have been reconciling diffs between CoreCLR and CoreRT, not much beyond that. The purpose comment was on both sides so I have kept it.
We have the purpose comment in number of files in the shared partition. I have deleted it only if it was deleted in CoreRT and it had zero information value.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
@jkotas I got lost in GitHub :-( Unfortunately, it's a common occurrence for me. Did I put the following comment in the right place? (wait for the in-page jump 1a9781b68b8ec66c223bb96f44ae1d2704ce6fdf#r33421958 It doesn't seem worth entering an issue on. |
Moved a batch of files to shared CoreLib partition, applying formatting and other changes from CoreRT as appropriate.