This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Exit gracefully when running ildasm -nat against unsupported ni file.#10821
Merged
jkotas merged 1 commit intodotnet:masterfrom Apr 8, 2017
mazong1123:fix-10247
Merged
Exit gracefully when running ildasm -nat against unsupported ni file.#10821jkotas merged 1 commit intodotnet:masterfrom mazong1123:fix-10247
jkotas merged 1 commit intodotnet:masterfrom
mazong1123:fix-10247
Conversation
ildasm -nat only works for fragile native images (ie CoreLib only by default). Running ildasm -nat against unsupported native images would cause a segmentation fault. This PR checks pNativeHeader->Signature == CORCOMPILE_SIGNATURE and end the program with a meaningful error message. fix #10247
Author
|
@jkotas Could you please take a look? Thanks :) |
Member
|
Thanks! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…dotnet/coreclr#10821) ildasm -nat only works for fragile native images (ie CoreLib only by default). Running ildasm -nat against unsupported native images would cause a segmentation fault. This PR checks pNativeHeader->Signature == CORCOMPILE_SIGNATURE and end the program with a meaningful error message. fix dotnet/coreclr#10247 Commit migrated from dotnet/coreclr@2024852
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ildasm -natonly works for fragile native images (ie CoreLib only by default).Running
ildasm -natagainst unsupported native images would cause a segmentation fault. This PR checks whetherpNativeHeader->SignatureisCORCOMPILE_SIGNATURE. If not, exits with a meaningful error message.fix #10247