Skip to content
This repository was archived by the owner on Jan 11, 2024. It is now read-only.

Updating the version of the roslyn compilers we use for building #1661

Merged
joperezr merged 4 commits into from
Sep 11, 2017
Merged

Updating the version of the roslyn compilers we use for building #1661

joperezr merged 4 commits into from
Sep 11, 2017

Conversation

@joperezr
Copy link
Member

@joperezr joperezr commented Sep 5, 2017

cc: @weshaggard @jaredpar @VSadov

Updating the version of roslyn compilers we use for building the repos. With these set of changes I'm able to build corefx in Windows and non-Windows succesfully.

jaredpar
jaredpar reviewed Sep 5, 2017
View reviewed changes
src/Microsoft.DotNet.Build.Tasks/PackageFiles/Build.Common.props Outdated
<BuildToolsTaskDir Condition="'$(RunningOnCore)'=='true'">$(ToolsDir)</BuildToolsTaskDir>
<UseRoslynCompilers Condition="'$(UseRoslynCompilers)'=='' and '$(RunningOnUnix)'=='true'">false</UseRoslynCompilers>
<UseSharedCompilation Condition="'$(UseSharedCompilation)' == '' and '$(RunningOnUnix)' != 'true' and '$(UseRoslynCompilers)' != 'false'">true</UseSharedCompilation>
<UseSharedCompilation>false</UseSharedCompilation>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dagood dagood mentioned this pull request Sep 8, 2017
Merged
weshaggard
weshaggard reviewed Sep 8, 2017
View reviewed changes
src/Microsoft.DotNet.Build.Tasks/PackageFiles/init-tools.sh
# Copy some roslyn files over
cp $__TOOLRUNTIME_DIR/runtimes/any/native/* $__TOOLRUNTIME_DIR/

#Temporarily rename roslyn compilers to have exe extension

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@VSadov
Copy link
Member

VSadov commented Sep 8, 2017 •
edited
Loading

@joperezr - There is a newer compiler package available - 2.6.0-rdonly-ref-62106-01 , but that adds some more checks and could potentially require source changes.
I'd prefer to get build working and then update to the newer version. - Just to do one thing at a time.

Once this change is in, we should move to a newer version though.

VSadov
VSadov approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joperezr joperezr mentioned this pull request Sep 11, 2017
Closed
@joperezr joperezr merged commit ef6e0ca into dotnet:master Sep 11, 2017
@joperezr joperezr deleted the UpdateRoslyn branch September 11, 2017 18:11
@ahsonkhan ahsonkhan mentioned this pull request Sep 11, 2017
Merged
@joperezr
Copy link
Member Author

joperezr commented Sep 12, 2017

temporarily rolling this back to unblock buildtools update in corefx, will re -add it once I have the changes ready in corefx for the update.

@joperezr
Copy link
Member Author

joperezr commented Sep 12, 2017

cc: @ericstj

@ericstj
Copy link
Member

ericstj commented Sep 12, 2017

Thanks @joperezr

joperezr added a commit to joperezr/buildtools that referenced this pull request Sep 12, 2017
@joperezr
Revert "Updating the version of the roslyn compilers we use for build…
4c825f3 
…ing (dotnet#1661)"

This reverts commit ef6e0ca.
joperezr added a commit that referenced this pull request Sep 12, 2017
@joperezr
Merge pull request #1673 from joperezr/RevertUpdate
5c346cd 
Revert "Updating the version of the roslyn compilers we use for building (#1661)"
@VSadov VSadov mentioned this pull request Sep 27, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@jaredpar jaredpar jaredpar left review comments

@eerhardt eerhardt eerhardt left review comments

@VSadov VSadov VSadov approved these changes

@weshaggard weshaggard weshaggard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joperezr @VSadov @ericstj @jaredpar @eerhardt @weshaggard @dnfclas