Skip to content

Fix OpenAPI schema ID collisions for duplicate type names#65871

Open
Bellambharath wants to merge 3 commits intodotnet:mainfrom
Bellambharath:fix/64325-openapi-schema-id-collisions
Open

Fix OpenAPI schema ID collisions for duplicate type names#65871
Bellambharath wants to merge 3 commits intodotnet:mainfrom
Bellambharath:fix/64325-openapi-schema-id-collisions

Conversation

@Bellambharath
Copy link
Copy Markdown

@Bellambharath Bellambharath commented Mar 19, 2026

Summary

  1. Deduplicate schema reference IDs when different types resolve to the same schema ID.
  2. Update CreateSchemaReferenceId tests to reflect non-nullable DateTime properties.
  3. Add test case for types with the same name in different namespaces.

Testing

  • dotnet test src/OpenApi/test/Microsoft.AspNetCore.OpenApi.Tests/Microsoft.AspNetCore.OpenApi.Tests.csproj --filter "FullyQualifiedName~CreateSchemaReferenceIdTests" -p:UseIisNativeAssets=false}

Fixes #64325

@Bellambharath Bellambharath requested a review from a team as a code owner March 19, 2026 12:10
@github-actions github-actions bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 19, 2026
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 19, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Thanks for your PR, @@Bellambharath. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ilonatommy added a commit that referenced this pull request Mar 20, 2026
)

These tests were unquarantined in #65864 but are failing again across
multiple PRs (#64964, #65871, #65451) in the Helix x64 Subset 2 job.
Re-quarantining only the RazorRuntimeCompilationHostingStartupTest
methods, not the RazorBuildTest ones.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ilonatommy added a commit that referenced this pull request Mar 20, 2026
) (#65881)

These tests were unquarantined in #65864 but are failing again across
multiple PRs (#64964, #65871, #65451) in the Helix x64 Subset 2 job.
Re-quarantining only the RazorRuntimeCompilationHostingStartupTest
methods, not the RazorBuildTest ones.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member feature-openapi pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAPI wrong schema generation

2 participants