[release/10.0-rc1] Empty "http.route" tags should be set to "/"#63336
Merged
wtgodbe merged 7 commits intorelease/10.0-rc1from Aug 20, 2025
Merged
[release/10.0-rc1] Empty "http.route" tags should be set to "/"#63336wtgodbe merged 7 commits intorelease/10.0-rc1from
wtgodbe merged 7 commits intorelease/10.0-rc1from
Conversation
These changes have been decided in #62431
Contributor
|
Hi @@github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
JamesNK
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62432 to release/10.0-rc1
/cc @sebastienros @Elanis
Empty "http.route" tags should be set to "/"
Normalizes empty routes to
/when used telemetry for thehttp.routetag.Description
Currently an empty route and
/are seen as two values for telemetry purposes. This PR uses/as the common value used in telemetry as they represent the same thing.Fixes #62431
Customer Impact
Wrong telemetry reported.
Some diagnostic tooling isn't happy with an empty string route value. Also, the meaning of an empty string route isn't immediately obvious. Using
/instead of empty string makes it clear that this route is for the root of the web app.Regression?
[If yes, specify the version the behavior has regressed from]
Risk
It's only changing a empty tag to
/to aggregate metrics correctly.Verification
Packaging changes reviewed?
When servicing release/2.1