Empty "http.route" tags should be set to "/"#62432
Merged
sebastienros merged 7 commits intodotnet:mainfrom Aug 19, 2025
Elanis:hosting-metrics-empty-http-route
Merged
Empty "http.route" tags should be set to "/"#62432sebastienros merged 7 commits intodotnet:mainfrom Elanis:hosting-metrics-empty-http-route
sebastienros merged 7 commits intodotnet:mainfrom
Elanis:hosting-metrics-empty-http-route
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
Contributor
Author
|
Feel free to ping me whenever someone in the team have time to review this :) And finally, if this feature can be backported in .NET 9 I would be extremely happy as it's producing lots of erroneous data in my monitoring stack 😅 (thus why I noticed this) |
1 task
Contributor
Author
|
(This PR is awaiting further discussions in #62431 ) |
Contributor
Author
|
Rebased on latest main, and applied changed decided in #62431 |
These changes have been decided in #62431
JamesNK
approved these changes
Aug 19, 2025
Member
|
@Elanis I rebased and updated the routing metric to be consistent. |
Contributor
Author
|
Thanks! |
BrennanConroy
approved these changes
Aug 19, 2025
Member
|
/backport to release/10.0-rc1 |
Contributor
|
Started backporting to release/10.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/17082938754 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostingMetrics: empty "http.route" tags shouldn't be present
When pushing metrics to third-party softwares such as prometheus. Having empty-valued labels will cause issues
Description
Microsoft.AspNetCore.Hostingcreate a metric calledhttp.server.request.durationdocumented here: https://learn.microsoft.com/en-us/aspnet/core/log-mon/metrics/built-inOne the available labels is
http.routewhich is optional.Issue:
http.routecan be populated with various string such as:And it can also be missing.
However, based on the OpenMetrics spec used by Prometheus, empty label values should be treated as if the label was not present.
That means when exporting data to prometheus, we currently create two different metrics (one for http_route= <empty string>, one for the missing http_route), which create a "duplicate sample for timestamp" error when importing data.
Fix:
To fix this issue, I changed the metric labelling so an empty route doesn't create the label, as if the variable was null.
Fixes #62431