Add pre-commit hook with code formatting#58965
Open
nazolek wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
Author
|
@dotnet-policy-service agree |
Contributor
|
Thanks for your PR, @nazolek. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Member
|
Thanks for the change! Looks like the original blocking issue has been fixed, and this does solve the build.sh problem - @SteveSandersonMS, any concerns with this approach? |
wtgodbe
approved these changes
Nov 19, 2024
Contributor
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Member
|
Hi @nazolek, is this still relevant? This would only work if the user ran build.sh/ps1, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre-commit hook with code formatter under the hood
In the context of PR, trying to solve an issue related to file formatting during pre-commit hook.
Description
The issue #30145 outlines the backward of the previous approach and why it was reverted. Based on that, wanna suggest some improvements:
Fixes #27632