Disable dotnet-format hook. Fixes #29768#30145
Merged
SteveSandersonMS merged 1 commit intomainfrom Feb 12, 2021
Merged
Conversation
Contributor
|
In the latest release, there are some breaking changes as well in format tool! The other thing that I wanted to mention here, the format seems slow, not sure if you guys are facing same issue, but I am having that issue, I thought it's because my machine issue, which works quite slow this days! |
javiercn
approved these changes
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although we are still interested in having a mechanism for this (#27632), we have realised that it's more complicated. The mechanism we merged before unfortunately has a series of problems which are having a negative effect on the development flow:
build.cmd, and not inbuild.shIssue 3 could be fixed easily, and issue 1 is probably not too bad to resolve, but issue 2 is rather tricky.
Rather than continue to produce random effects on each commit, let's disable this until we're ready to merge a solid implementation.