Skip to content

Add 'dotnet new' web item templates (razor view, api controller, mvc controller)#46714

Merged
mkArtakMSFT merged 3 commits intodotnet:mainfrom
deepchoudhery:main
Feb 24, 2023
Merged

Add 'dotnet new' web item templates (razor view, api controller, mvc controller)#46714
mkArtakMSFT merged 3 commits intodotnet:mainfrom
deepchoudhery:main

Conversation

@deepchoudhery
Copy link
Member

@deepchoudhery deepchoudhery commented Feb 16, 2023 •
edited
Loading

Add dotnet new web item templates

Summary of the changes (Less than 80 chars)

Description

added new dotnet new web item templates
Razor View:

  • added view (maybe should be razorview? feedback pls)
  • adds an empty razor view (Index.cshtml) to the project.
  • ConEmu64_pMamlKQhCQ

API Controller:

  • added apicontroller
  • adds an empty API Controller.
  • use --actions to add one with read/write actions.
  • ConEmu64_6rz00QQnZi

MVC Controller:

  • added mvccontroller
  • adds an empty MVC Controller.
  • use --actions to add one with read/write actions.
  • ConEmu64_UXdzbOuePN

Update the doc here for .NET 8??

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

deepchoudhery and others added 2 commits February 16, 2023 13:29
@deepchoudhery
add dotnet new templates (razor view, api controller, mvc controller) (…
a337e4f 
…#1)

* added razor view

* fix identity for razor view item template

* added api controller

* fixed api, added mvc controller

* pr comment fixes

* PR comment fixes 2
@deepchoudhery
fixing postActions.description
4a94fc4
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 16, 2023
@deepchoudhery deepchoudhery self-assigned this Feb 16, 2023
@deepchoudhery deepchoudhery marked this pull request as ready for review February 16, 2023 21:54
@deepchoudhery deepchoudhery assigned vijayrkn and unassigned vijayrkn Feb 16, 2023
@sebastienros
Copy link
Member

sebastienros commented Feb 16, 2023

This PR is failing on Failed Templates.Test.ByteOrderMarkTest.RazorFilesInWebProjects_ShouldContainBOM(projectName: "Web.ItemTemplates")

@deepchoudhery
Copy link
Member Author

deepchoudhery commented Feb 17, 2023

This PR is failing on Failed Templates.Test.ByteOrderMarkTest.RazorFilesInWebProjects_ShouldContainBOM(projectName: "Web.ItemTemplates")

changed encoding in VS Code for the template causing the issue, hoping that fixes it.

@build-analysis build-analysis bot mentioned this pull request Feb 17, 2023
Open
5 tasks
@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Feb 24, 2023

@deepchoudhery do you have permissions to merge or do you want me to merge this?

@vijayrkn
Copy link

vijayrkn commented Feb 24, 2023

@mkArtakMSFT - We don't have permissions to merge into this repo. Can you please merge?

@mkArtakMSFT mkArtakMSFT merged commit ecc1055 into dotnet:main Feb 24, 2023
@ghost ghost added this to the 8.0-preview2 milestone Feb 24, 2023
@dougbu dougbu mentioned this pull request Feb 25, 2023
Merged
dougbu added a commit that referenced this pull request Feb 28, 2023
@dougbu
Update template spelling and wording (#46886)
a580b5a 
* Update template spelling and wording
  - follow up to #46714
  - correct 'ReadWrite' and 'Am'

* Address code review comments
  - no need to change post-action `description`s

* Capitalize as agreed in PR
  - also, update English resources to match template.json content

* Build to propagate strings
  - fill in missed files in localize/ folder
@deepchoudhery deepchoudhery mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vijayrkn vijayrkn Awaiting requested review from vijayrkn

@sayedihashimi sayedihashimi Awaiting requested review from sayedihashimi

@Nick-Stanton Nick-Stanton Awaiting requested review from Nick-Stanton

@javiercn javiercn Awaiting requested review from javiercn

@DamianEdwards DamianEdwards Awaiting requested review from DamianEdwards

@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck

1 more reviewer

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@deepchoudhery deepchoudhery

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

8.0-preview2

Development

Successfully merging this pull request may close these issues.

4 participants

@deepchoudhery @sebastienros @mkArtakMSFT @vijayrkn