[blazor] remove custom loader for .wasm file#45611
Merged
wtgodbe merged 1 commit intodotnet:darc-main-8caa276f-464b-4e95-a7fa-bc264a536653from Dec 15, 2022
Conversation
wtgodbe
approved these changes
Dec 15, 2022
29db4a4
into
dotnet:darc-main-8caa276f-464b-4e95-a7fa-bc264a536653
dotnet-maestro bot
added a commit
that referenced
this pull request
Dec 15, 2022
[main] Update dependencies from dotnet/efcore dotnet/runtime - Update templatestrings.json files - Update template.json files - Update other references to net7 - Rename publicApi folders - Fix RepoTasks - Fix it more fixily - Really fix it for real this time - Undo PreviewFeatures changes - Using - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Tasks - IO - CTS - Net70 - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Try using net8.0 for HelixTestRunner - Try making ReferenceAssemblies - Merge branch 'darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' of https://github.com/dotnet/aspnetcore into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Get analyzer tests working - Ok fine - Update doc - Path combine - Try somethin wacky - Fix - Using - Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Quarantine regressed WriteAsJsonAsync tests #45557 - Quarantine regressed async Json test #45557 - Re-order DataAnnotationsMetadataProviderTest expected results - Quarantine regressed async Json test #45557 - Re-order DataAnnotationsMetadataProviderTest expected results - Merge remote-tracking branch 'upstream/main' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Bump E2E timeout to 2 hours Per discussion in #44834 (comment) - React to enum ordering change - Merge remote-tracking branch 'upstream/darc-main-8caa276f-464b-4e95-a7fa-bc264a536653' into darc-main-8caa276f-464b-4e95-a7fa-bc264a536653 - Skip a microbenchmark, update a version - Make test resilient to order changes - Unquar tests - remove custom loader for .wasm file (#45611)
TanayParikh
reviewed
Dec 15, 2022
Contributor
TanayParikh
left a comment
There was a problem hiding this comment.
Thanks @pavelsavara!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for blazor wasm startup issue
The issue is caused by removal of obsolete generated code, which is supplemented another way in the default runtime startup sequence.
https://github.com/dotnet/runtime/pull/79466/files#diff-68c787b9334a397c996fd6183dec57c08c883c8fba04cafc6387491c2b7f8452L124
I prefer to reduce the difference in startup sequence.
There further differences which could be eliminated, but rather on proper PR.