Skip to content

Update Roslyn versions#44072

Merged
TanayParikh merged 2 commits intomainfrom
TanayParikh-patch-2
Sep 26, 2022
Merged

Update Roslyn versions#44072
TanayParikh merged 2 commits intomainfrom
TanayParikh-patch-2

Conversation

@TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Sep 19, 2022 •
edited
Loading

Uses the MicrosoftNetCompilersToolsetPackageVersion from https://github.com/dotnet/sdk/blob/release/7.0.1xx/eng/Versions.props.

For: #39387

Note this'll need to be back-ported to 7.0 as well.

References:

@TanayParikh TanayParikh added the area-blazor Includes: Blazor, Razor Components label Sep 19, 2022
@TanayParikh TanayParikh added this to the 7.0.0 milestone Sep 19, 2022
@TanayParikh TanayParikh requested review from a team, dagood, jaredpar and mmitche September 19, 2022 23:37
@TanayParikh TanayParikh requested review from a team, dougbu and wtgodbe as code owners September 19, 2022 23:37
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 19, 2022
dougbu
dougbu reviewed Sep 20, 2022
View reviewed changes
@JamesNK
Copy link
Member

JamesNK commented Sep 20, 2022 •
edited
Loading

Note this'll need to be back-ported to 7.0 as well.

I don't think these version numbers should be used in release/7.0. I believe 7.0 is supposed to run in VS 17.3, which ships 4.3.0 of these assemblies.

A better place to look to is dotnet/runtime: https://github.com/dotnet/runtime/blob/release/7.0/eng/Versions.props#L47-L51

@mmitche
Copy link
Member

mmitche commented Sep 20, 2022

I think we should have these dependencies also called out in Version.Details.xml. That will be required for source build at some point in the .NET 8 timeframe anyway.

@TanayParikh TanayParikh changed the title Update to stable Roslyn versions Update Roslyn versions Sep 20, 2022
TanayParikh
TanayParikh commented Sep 20, 2022
View reviewed changes
eng/Versions.props Outdated
Comment on lines +212 to +210
<MicrosoftCodeAnalysisCSharpWorkspacesVersion>4.2.0-2.22128.1</MicrosoftCodeAnalysisCSharpWorkspacesVersion>
<MicrosoftCodeAnalysisCommonVersion>4.4.0-2.22464.20</MicrosoftCodeAnalysisCommonVersion>
Copy link
Contributor Author

@TanayParikh TanayParikh Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredpar just wanted to confirm versioning with you.

For main (this PR), is 4.4.0-2.22464.20 (from sdk appropriate?

Likewise, for release/7.0, would 4.3.0-2.final (from runtime) be appropriate?

Copy link
Member

@jaredpar jaredpar Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For main (this PR), is 4.4.0-2.22464.20 (from sdk appropriate?

What relesae are you updating for?

Copy link
Contributor Author

@TanayParikh TanayParikh Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main targets 8.0 now, so I believe .NET 8 Preview 1? Honestly not too concerned about main at the moment, the focus is on getting the appropriate versioning for release/7.0.

Copy link
Member

@jaredpar jaredpar Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For release/7.0 use version 4.4.0-3.22472.13. Make sure you have the following feed in your restore sources

https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json

TanayParikh added a commit that referenced this pull request Sep 23, 2022
@TanayParikh
[release/7.0] Update Roslyn Versions
2a3027f 
Using the roslyn versions provided by @jaredpar: #44072 (comment)

For: #39387

References:
- #28125
- #37764
- #44072
@TanayParikh TanayParikh mentioned this pull request Sep 23, 2022
Merged
10 tasks
dougbu
dougbu reviewed Sep 23, 2022
View reviewed changes
@TanayParikh TanayParikh merged commit f15af7b into main Sep 26, 2022
@TanayParikh TanayParikh deleted the TanayParikh-patch-2 branch September 26, 2022 15:45
@ghost ghost modified the milestones: 7.0.0, 8.0-preview1 Sep 26, 2022
mkArtakMSFT pushed a commit that referenced this pull request Sep 29, 2022
@TanayParikh
[release/7.0] Update Roslyn Versions (#44148)
ed649ac 
Using the roslyn versions provided by @jaredpar: #44072 (comment)

For: #39387

References:
- #28125
- #37764
- #44072
@TanayParikh TanayParikh mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

@mmitche mmitche Awaiting requested review from mmitche

@dagood dagood Awaiting requested review from dagood

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

+1 more reviewer

@dougbu dougbu dougbu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

5 participants

@TanayParikh @JamesNK @mmitche @jaredpar @dougbu