Merged
Conversation
6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8 aspnet/MessagePack-CSharp#2
dougbu
approved these changes
Aug 22, 2022
Contributor
dougbu
left a comment
There was a problem hiding this comment.
Looks fine but I suggest backporting at least to release/7.0 (for RC2), if not release/7.0-rc1
Contributor
Author
On second thought let's maybe do RC2 (release/7.0). This is completed untested, and I don't want to push that into RC1 at this point. |
TanayParikh
added a commit
that referenced
this pull request
Aug 22, 2022
6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8 aspnet/MessagePack-CSharp#2 Backport #43474
Contributor
Author
wtgodbe
pushed a commit
that referenced
this pull request
Aug 23, 2022
6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8 aspnet/MessagePack-CSharp#2 Backport #43474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8
aspnet/MessagePack-CSharp#2