[release/7.0-rc1] HTTP/3 flaky test retries and logging#43423
Merged
adityamandaleeka merged 2 commits intorelease/7.0-rc1from Aug 25, 2022
Merged
[release/7.0-rc1] HTTP/3 flaky test retries and logging#43423adityamandaleeka merged 2 commits intorelease/7.0-rc1from
adityamandaleeka merged 2 commits intorelease/7.0-rc1from
Conversation
dougbu
approved these changes
Aug 20, 2022
| public async Task StreamPool_StreamAbortedOnClientAndServer_NotPooled() | ||
| { | ||
| // Arrange | ||
| using var httpEventSource = new HttpEventSourceListener(LoggerFactory); |
Member
Author
There was a problem hiding this comment.
Correct. It registers an event source in the constructor and removes it on dispose. Since no one uses it, it could be changed to:
using var _ = new HttpEventSourceListener(LoggerFactory);But I'd prefer to do that in a separate PR to remove them all at once. Personally, I'm happy leaving it as is.
|
|
||
| public static class ServerRetryHelper | ||
| { | ||
| private const int RetryCount = 15; |
Contributor
There was a problem hiding this comment.
nit: There's no delay in the loop below beyond connection timeouts. Suggest going higher if I'm right that address in use normally causes an almost-immediate failure.
| public async Task POST_ClientSendsOnlyHeaders_RequestReceivedOnServer(HttpProtocols protocol) | ||
| { | ||
| // Arrange | ||
| using var httpEventSource = new HttpEventSourceListener(LoggerFactory); |
Merged
Contributor
|
Any reason this hasn't been checked in @adityamandaleeka @JamesNK❔ |
Member
Author
|
Waiting on @adityamandaleeka approval 🙏 |
4 tasks
Member
|
Sorry, I hadn't seen this one. Approved, test-only changes. |
Member
Author
|
I forgot to add you 😄 |
halter73
pushed a commit
to halter73/AspNetCore
that referenced
this pull request
Nov 20, 2024
* HTTP/3 flaky test retries and logging * Rewrite retry helper to get ports via binding port to 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address various pipeline failures:
More retries will hopefully remove one set of failures. More logging to find solutions for others in the future. System.Net.Quic team is still making changes, so it can be a source of instability.
Test only changes.