WebTransport interfaces require preview features#43419
WebTransport interfaces require preview features#43419adityamandaleeka merged 1 commit intorelease/7.0-rc1from
Conversation
AcceptAsync already had this. This just extends the treatment to the entire interface so we can make breaking changes to this API in a later release. We think we might expose a MultiplexedConnectionContext.
| using Microsoft.AspNetCore.Http.Features.Authentication; | ||
| using Microsoft.AspNetCore.Server.Kestrel.Core.Features; | ||
|
|
||
| #pragma warning disable CA2252 // WebTransport is a preview feature |
There was a problem hiding this comment.
I think this is what Daniel was telling me for a reason he didn't set the preview attribute higher, it's a bit viral. But it's better from a "we can break this in the future" perspective.
By suppressing it normal apps won't see the warning until they touch IHttpWebTransportFeature or IWebTransportSession right?
There was a problem hiding this comment.
By suppressing it normal apps won't see the warning until they touch
IHttpWebTransportFeatureorIWebTransportSessionright?
Correct. If we don't mark the entire interfaces as previews, we'd theoretically be unable to make changes in a future release that break any callers to or implementers of these interfaces.
There was a problem hiding this comment.
Yeah, this is exactly why we didn't do it this way earlier. Your fix is correct, but annoying to work with 😁
|
@adityamandaleeka Can we merge this into rc1? |
|
Approved. |
AcceptAsync already had this. This just extends the treatment to the entire interface so we can make breaking changes to this API in a later release. We think we might expose a MultiplexedConnectionContext.
AcceptAsync already had the
[RequiresPreviewFeatures]. This just extends the treatment to the entire interface so we can make breaking changes to this API in a later release. We think we might expose aMultiplexedConnectionContextdown the road.Closes #42490