[Blazor] Backport to RC1 of Applies API review feedback and removes byte array APIs from the public API surface#35769
Merged
Pilchie merged 3 commits intorelease/6.0-rc1from Aug 26, 2021
Conversation
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Member
Member
Author
|
@Pilchie let's merge it now. I'll apply the feedback on main, since they are style comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #35768
Customer impact
This is a feature that we added in 6.0 to support customers that are prerendering their Blazor applications and that allows them to save state and then access it the next time the app starts after it has been prerendered.
Most changes are renaming for APIs that a customer doesn't ever interact with (because he can't extend the type nor call methods on it in a way that is useful; the APIs are public because of layering constraints between Blazor Server/Wasm and Mvc.)
This is not a core feature of the framework, so we are changing somethign that only a few folks will use (say 10% to put a number on it).
Of the APIs, the ones a customer will interact 99% of the time are below and the updates are very straighforward:
Here is a sample of the 99% use case for the feature:
Other renames/changes are for types that are public that customers don't directly use.
Testing
Automated. We have unit tests and E2E test coverage for all the changed APIs.
Risk
Low