Skip to content

[Blazor] Applies API review feedback and removes byte array APIs from the public API surface#35768

Merged
javiercn merged 4 commits intomainfrom
javiercn/apply-persistence-api-review-feedback-no-spanified-apis
Aug 27, 2021
Merged

[Blazor] Applies API review feedback and removes byte array APIs from the public API surface#35768
javiercn merged 4 commits intomainfrom
javiercn/apply-persistence-api-review-feedback-no-spanified-apis

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Aug 26, 2021 •
edited
Loading

Renames

  • Lifetime -> Infrastructure
    • ComponentApplicationLifetime -> ComponentStatePersistenceManager
    • ComponentApplicationState -> PersistentComponentState
    • OnPersisting -> Subscription RegisterOnPersisting(Func callback)
    • IComponentApplicationStateStore -> IComponentPersistedStateStore

@javiercn javiercn requested review from a team, Pilchie and pranavkm as code owners August 26, 2021 12:07
@javiercn javiercn mentioned this pull request Aug 26, 2021
Merged
@javiercn javiercn force-pushed the javiercn/apply-persistence-api-review-feedback-no-spanified-apis branch from d079fa6 to 53ad637 Compare August 26, 2021 12:55
@TanayParikh
Copy link
Contributor

TanayParikh commented Aug 26, 2021

Just did a quick parse and I'm seeing Base64 encoding/serialization of byte arrays. Is there an opportunity to leverage the byte[] interop to optimize this area?

@javiercn
Copy link
Member Author

javiercn commented Aug 26, 2021

Just did a quick parse and I'm seeing Base64 encoding/serialization of byte arrays. Is there an opportunity to leverage the byte[] interop to optimize this area?

nope, all these things happen outside of blazor.

@Pilchie Pilchie changed the title [Blazor] Applies API review feedback and removes bite array APIs from the public API surface [Blazor] Applies API review feedback and removes byte array APIs from the public API surface Aug 26, 2021
pranavkm
pranavkm approved these changes Aug 26, 2021
View reviewed changes
@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Aug 26, 2021
@javiercn javiercn force-pushed the javiercn/apply-persistence-api-review-feedback-no-spanified-apis branch from 53ad637 to b1d7ab9 Compare August 27, 2021 10:37
@javiercn javiercn force-pushed the javiercn/apply-persistence-api-review-feedback-no-spanified-apis branch from b1d7ab9 to e9124de Compare August 27, 2021 11:59
@javiercn javiercn merged commit b849efe into main Aug 27, 2021
@javiercn javiercn deleted the javiercn/apply-persistence-api-review-feedback-no-spanified-apis branch August 27, 2021 15:38
@ghost ghost added this to the 7.0-preview1 milestone Aug 27, 2021
@javiercn javiercn modified the milestones: 7.0-preview1, 6.0.0 Aug 27, 2021
@pranavkm pranavkm mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pilchie Pilchie Awaiting requested review from Pilchie

2 more reviewers

@pranavkm pranavkm pranavkm approved these changes

@TanayParikh TanayParikh TanayParikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@javiercn @TanayParikh @pranavkm @Pilchie