Add file_header_template to editorconfig#30132
Add file_header_template to editorconfig#30132Youssef1313 wants to merge 52 commits intodotnet:mainfrom
Conversation
|
Before moving forward with applying a FixAll in more solution filters, can someone confirm you want this change? |
Pilchie
left a comment
There was a problem hiding this comment.
This is super valuable, but likely to be a bit tricky. It might be easier to move directly to MIT, since parts of the repo are already licensed that way, and that's where we want to end up.
src/Http/Routing/src/ArrayBuilder.cs
Outdated
There was a problem hiding this comment.
This is incorrect, since it's copied source from something that was MIT.
There was a problem hiding this comment.
@Pilchie Is there a list of solution filters that I shouldn't touch their license headers?
src/Caching/SqlServer/src/Columns.cs
Outdated
There was a problem hiding this comment.
This code in Caching moved from dotnet/extensions which was MIT.
There was a problem hiding this comment.
The HttpClientFactory stuff also came from extensions.
|
Related to #18873. |
|
Using Upgrading the compiler version introduced some nullable errors. I think I'll wait on this PR until you upgrade the compiler version and fix these errors. I'll convert to a draft until you move to the newer compiler version or I get to do this in a separate PR. |
|
@dougbu Can you comment on #30132 (comment)? |
|
The Build team doesn't treat the compiler version as infrastructure unless (and, yes, this has happened) a new version causes problems. We pinned the version to keep aspnetcore ahead of Arcade IIRC. I have no general concerns about moving from 3.7.x to 3.10.x. Suggest working with @JamesNK and @pranavkm, both of whom have done a large amount of nullability-related changes. @Youssef1313 where were most of the new warnings or errors❔ |
|
@dougbu |
Done #31403 |
|
@Pilchie The size of the PR is growing crazy. Is that okay? |
|
Is it possible to only apply this to part of the repo at a time? |
Yes, I can cherry-pick the commits here to multiple PRs. Would you be able to let me know which directories are owned by the same team to open as a separate PRs? |
|
There are probably 5 main areas: |
|
Sorry @Youssef1313, we ran into a bureaucratic hurdle. We'll get it sorted out and get back to you here soon. |
|
Closing this in lieu of #34573. Thanks for your time and effort though! |
Uh oh!
There was an error while loading. Please reload this page.