@karolz-ms this test timed out (was 45 sec timeout, this is with the new 180sec CI-only timeout even). I assume it's hung (?)

2025-04-16T01:20:16.7357658Z [xUnit.net 00:04:01.22]         | [2025-04-16T01:20:08] Aspire.Hosting.Dcp.dcpproc.monitor Information: monitor process exited, shutting down	{"pid": 6150}
2025-04-16T01:20:16.7358641Z   Failed Aspire.Hosting.Tests.DistributedApplicationTests.SpecifyingEnvPortInEndpointFlowsToEnv [3 m 11 s]
2025-04-16T01:20:16.7358775Z   Error Message:
2025-04-16T01:20:16.7359649Z    System.TimeoutException : The operation at /_/tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs:602 timed out after reaching the limit of 180000ms.

Can you get a clue from the log?

If you'd pushed in the main trunk, we'd be able to run the outerloop and the full AzDO CI builds.

If you'd pushed in the main trunk, we'd be able to run the outerloop and the full AzDO CI builds.

I don't follow :)

If you'd pushed in the main trunk, we'd be able to run the outerloop and the full AzDO CI builds.

I don't follow :)

You're working off your fork (kudos!), but this makes us unable to fully test this change. If you were to push into a branch on the main trunk (i.e., to dotnet/aspire instead of danmoseley/aspire), we could schedule an outerloop run for that branch as well as a full CI build in AzDO.

We don't execute all tests for pull-requests, so we can't be 100% certain until we test all test workflows.

Before merging:

• Run all the tests on azdo
• Run the Outerloop tests workflow
• Confirm that local runs are not broken
• Check running from VS?
• check build/test/debug in Codespaces

We don't execute all tests for pull-requests, so we can't be 100% certain until we test all test workflows.

I can push and trigger a run. https://dev.azure.com/dnceng-public/public/_build?definitionId=274&_a=summary

Outerloop validation run - https://github.com/dotnet/aspire/actions/runs/14484113484

@RussKie QuarantinedTestRunsheetBuilder : error : Search failed https://github.com/dotnet/aspire/actions/runs/14484113484/job/40626482806

@RussKie QuarantinedTestRunsheetBuilder : error : Search failed dotnet/aspire/actions/runs/14484113484/job/40626482806

Boo.... Looking

Before merging:

• Run all the tests on azdo
• Run the Outerloop tests workflow
• Confirm that local runs are not broken
• Check running from VS?

Can we add check build/test/debug in Codespaces to this list?

I've validated that reverted the PR fixes debugging tests locally but other should sanity check as well.

cc: @mitchdenny

@danmoseley we need to apply this patch:
0001-Roll-back-QuarantinedTestRunsheetBuilder.patch

...or use this:
QuarantinedTestRunsheetBuilder.targets.txt

@captainsafia @danmoseley @RussKie I'm not able to reproduce issues with VS Code DevKit.

Also in the potential workaround I suggested to @captainsafia, I forgot to mention one more required thing, which I wrote now in #8498 (comment). Could we wait until the workaround is tested please? or more info is gathered as I cannot reproduce locally?

@Youssef1313 I reproduced being unable to debug a test using the following:

1. Opened this PR in a Codespace.
2. Built one of the test projects and waited for it to show up in test explorer.
3. Right clicked and selected the test to debug.

Got this error:

Opened this PR

I assume you refer to #8498, and not this PR (#8802)?

For MTP to work in VSCode, you need DevKit. If you don't use DevKit, then only VSTest is supported, which can be simply worked around by adding Microsoft.NET.Test.Sdk and xunit.runner.visualstudio packages.

@Youssef1313 Are you on reproing on Windows? The issue seems to be related to macOS/Linux.

I hopped on a couple of calls yesterday with @ocallesp on the VS Code team and he was able to reproduce the issue in those environments.

which can be simply worked around by adding Microsoft.NET.Test.Sdk and xunit.runner.visualstudio packages.'

I believe I attempted this workaround based on your comment here but didn't have success with it.

@captainsafia My comment wasn't complete as I forgot to mention another package. Have you tried with both packages? Can you send me logs with the two packages being included?

@Youssef1313 Could you open a draft PR that demonstrates the workaround you think would help here? That might make it easier.

@captainsafia Indeed. Will do it in few minutes.

Hmm, Microsoft.NET.Test.Sdk is actually implicitly included via Arcade, but I don't know if it could be that the version is too old. Could you try with #8819, and re-share the logs please?

Regarding that it's macOS/Linux specific, that's good information, as I was trying on Windows.

@danmoseley we need to apply this patch: 0001-Roll-back-QuarantinedTestRunsheetBuilder.patch

...or use this: QuarantinedTestRunsheetBuilder.targets.txt

done -- btw, you can push yourself to this PR, no perms required :)

If you'd pushed in the main trunk, we'd be able to run the outerloop and the full AzDO CI builds.

Ah trunk == repo

Hmm, Microsoft.NET.Test.Sdk is actually implicitly included via Arcade, but I don't know if it could be that the version is too old. Could you try with #8819, and re-share the logs please?

The changeset in that PR doesn't seem to build?

Regarding that it's macOS/Linux specific, that's good information, as I was trying on Windows.

You should be able to reproduce this in Linux on Codespaces as well since @mitchdenny is running into the problem as well and that's his VS Code setup.

Timed out at 04/16/2025 15:29:09 after 60000ms waiting for remote process.
...
 Failed Aspire.Azure.Storage.Queues.Tests.ConformanceTests.TracingEnablesTheRightActivitySource_Keyed

Impossible to say why it timed out as the callstack is from the waiting process not the child.

Do we want to merge this? need signoff/s.

This broke outerloop test runs. Only a few test projects are running now - https://github.com/dotnet/aspire/actions/runs/14501563823/job/40682240457 .