Stop health checks running until the underlying resource enters the running state.#5601
Merged
mitchdenny merged 8 commits intomainfrom Sep 10, 2024
Merged
Stop health checks running until the underlying resource enters the running state.#5601mitchdenny merged 8 commits intomainfrom
mitchdenny merged 8 commits intomainfrom
Conversation
davidfowl
reviewed
Sep 9, 2024
davidfowl
reviewed
Sep 9, 2024
src/Aspire.ProjectTemplates/templates/aspire-empty/AspireApplication.1.AppHost/appsettings.json
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 9, 2024
davidfowl
reviewed
Sep 9, 2024
playground/ProxylessEndToEnd/ProxylessEndToEnd.AppHost/appsettings.json
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 9, 2024
playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.AppHost/appsettings.json
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 9, 2024
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
approved these changes
Sep 9, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidfowl
reviewed
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a service to the container which replaces the predicate on
HealthCheckPublisherOptionsand only enables checks when a resource associated with it is in a Running state (once enabled they stay enabled). It also reduces the period to 5 seconds.Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow