Skip to content

Stop health checks running until the underlying resource enters the running state.#5601

Merged
mitchdenny merged 8 commits intomainfrom
mitchdenny/healthcheck-control
Sep 10, 2024
Merged

Stop health checks running until the underlying resource enters the running state.#5601
mitchdenny merged 8 commits intomainfrom
mitchdenny/healthcheck-control

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 9, 2024

Description

Adds a service to the container which replaces the predicate on HealthCheckPublisherOptions and only enables checks when a resource associated with it is in a Running state (once enabled they stay enabled). It also reduces the period to 5 seconds.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No (existing tests cover this, if it isn't working the tests will fail)
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 9, 2024
@mitchdenny mitchdenny requested a review from davidfowl September 9, 2024 11:25
mitchdenny and others added 4 commits September 10, 2024 01:09
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
@davidfowl davidfowl added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 9, 2024
@mitchdenny mitchdenny enabled auto-merge (squash) September 9, 2024 15:13
@davidfowl
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit f29be7b into main Sep 10, 2024
@mitchdenny mitchdenny deleted the mitchdenny/healthcheck-control branch September 10, 2024 03:39
radical pushed a commit to radical/aspire that referenced this pull request Sep 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants