Skip to content

Update container logs available condition to allow streaming build logs.#4601

Merged
mitchdenny merged 1 commit intomainfrom
mitchdenny/change-logsavailable-toallow-startbuild-streaming
Jun 20, 2024
Merged

Update container logs available condition to allow streaming build logs.#4601
mitchdenny merged 1 commit intomainfrom
mitchdenny/change-logsavailable-toallow-startbuild-streaming

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Jun 20, 2024 •
edited by dotnet-policy-service bot
Loading

This PR updates the LogsAvailable condition to include both Starting and Building states so that logs streaming can happen at those earlier stages.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jun 20, 2024
@mitchdenny mitchdenny requested a review from danegsta June 20, 2024 00:33
@mitchdenny mitchdenny self-assigned this Jun 20, 2024
@mitchdenny mitchdenny added this to the 8.1 milestone Jun 20, 2024
@mitchdenny mitchdenny merged commit 521a2c6 into main Jun 20, 2024
@mitchdenny mitchdenny deleted the mitchdenny/change-logsavailable-toallow-startbuild-streaming branch June 20, 2024 05:36
radical pushed a commit to radical/aspire that referenced this pull request Jun 20, 2024
@mitchdenny @radical
Update container logs available condition to allow streaming build lo…
b1b0682 
…gs. (dotnet#4601)
This was referenced Jun 26, 2024
Closed
Closed
radical added a commit to radical/aspire that referenced this pull request Jun 30, 2024
@radical
Squashed commit of the following:
2753f24 
commit 14b5e2f
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 20 14:55:40 2024 -0400

    Fix Aspire.Hosting.Testing.Tests.TestingFactoryTests.HttpClientGetTest by using httpclient with resilience

commit 251d59a
Merge: ac52e88 bae6c46
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 20 14:14:26 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

commit ac52e88
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 20 14:11:27 2024 -0400

    address review feedback from @ eerhardt

commit b1b0682
Author: Mitch Denny <midenn@microsoft.com>
Date:   Wed Jun 19 22:36:45 2024 -0700

    Update container logs available condition to allow streaming build logs. (dotnet#4601)

commit f9e2eba
Author: David Negstad <50252651+danegsta@users.noreply.github.com>
Date:   Wed Jun 19 17:17:55 2024 -0700

    Update additional DCP resource schema (dotnet#4600)

commit 023fd5c
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Jun 19 21:57:14 2024 +0000

    Update dependencies from https://github.com/microsoft/usvc-apiserver build 0.5.3 (dotnet#4598)

    [main] Update dependencies from microsoft/usvc-apiserver

commit fd2474e
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 20 14:12:39 2024 -0400

    Update tests/TestingAppHost1/TestingAppHost1.AppHost/TestingAppHost1.AppHost.csproj

    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

commit fe32fd3
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 19 20:43:42 2024 -0400

    Use `b.AddStandardResilienceHandler`

commit c5f7f3e
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 19 18:26:28 2024 -0400

    Add resilience handlers in the test itself

commit fb788aa
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 19 17:16:23 2024 -0400

    Disable failing test `ProxylessAndProxiedEndpointBothWorkOnSameResource`

    Issue: dotnet#4599

commit fa3bce0
Merge: c0743ee 4e06e32
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 19 17:12:14 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

commit c0743ee
Merge: 5e28b57 faf26a8
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 19 16:12:32 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

commit 5e28b57
Merge: abad241 01f7399
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 18 15:40:52 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

commit abad241
Merge: 4038329 c3d1e74
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 18 13:11:13 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

commit 4038329
Merge: 4335fa0 c294706
Author: Ankit Jain <radical@gmail.com>
Date:   Mon Jun 17 18:34:51 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

commit 4335fa0
Author: Ankit Jain <radical@gmail.com>
Date:   Mon Jun 17 18:16:48 2024 -0400

    DistributedApplicationTests.cs: Bump timeout for docker based tests from 10secs for 1min

commit b32414e
Merge: 0742f8a 8e311f3
Author: Ankit Jain <radical@gmail.com>
Date:   Mon Jun 17 15:05:08 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

commit 0742f8a
Merge: aa72d39 d447bda
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 15 04:23:59 2024 -0400

    Merge remote-tracking branch 'origin/main' into hosting-testing-build

    # Conflicts:
    #	tests/Aspire.Components.Common.Tests/RequiresDockerAttribute.cs
    #	tests/Aspire.Hosting.Tests/Schema/SchemaTests.cs

commit aa72d39
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 14 23:19:13 2024 -0400

    Remove SkipOnHelixTheory, and SkipOnHelixFact attributes

commit d2d7a18
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 14 19:41:00 2024 -0400

    cleanup

commit 36654c0
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 14 19:03:42 2024 -0400

    cleanup

commit 6fb3c82
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 14 19:02:42 2024 -0400

    TestingAppHost1.AppHost: add default resilience handler

commit 322b8e1
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 14 18:38:59 2024 -0400

    Add resilience handler to httpclient in Hosting.Testing tests

commit 61fd312
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 22:43:50 2024 -0400

    fix typo

commit 08a8299
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 22:43:31 2024 -0400

    Add RequiresTools attributes, and use for the node/npm tests

commit f4c4a77
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 21:54:45 2024 -0400

    Disable node/npm tests on CI as the binaries are not available

commit daccd46
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 21:26:08 2024 -0400

    cleanup

commit 6913816
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 21:24:49 2024 -0400

    [tests] Remove RequiresDocker from Hosting.Tests that don't need it

commit 106ed06
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 21:05:44 2024 -0400

    [tests] Split npm/nodeapp test

commit 502e36f
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 19:48:47 2024 -0400

    FIXME: add delay in ProxylessAndProxiedEndpointBothWorkOnSameResource to wait for all the endpoints to get allocated

commit a85b721
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 17:44:18 2024 -0400

    [tests] Fix VerifyNodeAppWorks by fixing the constructed path to nodeapp

commit cbc7897
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 17:40:24 2024 -0400

    [tests] FIXME: add delay to wait for the webapp to be ready

commit ca5d62f
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 17:37:25 2024 -0400

    [tests] Throw if application hasn't been initialized, useful for debugging issues

commit 78dc7a2
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 17:36:45 2024 -0400

    [tests] Install devcerts on linux/CI

commit fc2bf4f
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 13 17:36:01 2024 -0400

    [tests] Use RequiresDocker instead of LocalOnlyFact/Theory attributes

    - this allows the tests to run on the build machine

commit 3d8949c
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 12 21:30:41 2024 -0400

    [tests] Use .runsettings when running non-helix tests, so tests skipping can work

    To be specific, `category!=failing` is required.

commit 9c964a6
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 12 21:28:43 2024 -0400

    [tests] RequiresDocker: Update condition to disallow docker based tests

    .. on windows/build-machine on CI.

# Conflicts:
#	eng/pipelines/templates/BuildAndTest.yml
#	tests/Aspire.Hosting.Testing.Tests/TestingBuilderTests.cs
#	tests/Aspire.Hosting.Testing.Tests/TestingFactoryCrashTests.cs
#	tests/Aspire.Hosting.Testing.Tests/TestingFactoryTests.cs
#	tests/Aspire.Hosting.Tests/SlimTestProgramTests.cs
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danegsta danegsta danegsta approved these changes

Assignees

@mitchdenny mitchdenny

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitchdenny @danegsta