Add 3rd-party signing entries for Sigstore, Tuf, and NSec.Cryptography#14915
Merged
radical merged 1 commit intorelease/13.2from Mar 3, 2026
Merged
Add 3rd-party signing entries for Sigstore, Tuf, and NSec.Cryptography#14915radical merged 1 commit intorelease/13.2from
radical merged 1 commit intorelease/13.2from
Conversation
The Sigstore and Tuf NuGet packages (and their transitive dependency NSec.Cryptography) were added to Aspire.Cli in #14569 but the corresponding FileSignInfo entries in eng/Signing.props were not added. This causes SIGN004 errors in the internal build because the Arcade SDK detects 3rd-party DLLs being signed with the Microsoft certificate. Add FileSignInfo entries with CertificateName="3PartySHA2" for: - NSec.Cryptography.dll (transitive dep, © Klaus Hartke) - Sigstore.dll (direct dep) - Tuf.dll (direct dep) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14915Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14915" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Arcade signing configuration to address SIGN004 failures in the internal build by explicitly marking newly introduced 3rd-party assemblies for 3rd-party certificate signing.
Changes:
- Adds
FileSignInfoentries forNSec.Cryptography.dll,Sigstore.dll, andTuf.dll. - Configures these assemblies to use
CertificateName="3PartySHA2"to satisfy Arcade 3rd-party signing validation.
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22644212359 |
DamianEdwards
approved these changes
Mar 3, 2026
eerhardt
approved these changes
Mar 3, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
#14915) The Sigstore and Tuf NuGet packages (and their transitive dependency NSec.Cryptography) were added to Aspire.Cli in #14569 but the corresponding FileSignInfo entries in eng/Signing.props were not added. This causes SIGN004 errors in the internal build because the Arcade SDK detects 3rd-party DLLs being signed with the Microsoft certificate. Add FileSignInfo entries with CertificateName="3PartySHA2" for: - NSec.Cryptography.dll (transitive dep, © Klaus Hartke) - Sigstore.dll (direct dep) - Tuf.dll (direct dep) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SIGN004 build failures in dotnet-aspire internal pipeline
The dotnet-aspire internal build is failing with
SIGN004errors:These 3rd-party DLLs were introduced in #14569 when
SigstoreandTufNuGet packages were added toAspire.Cli, but the correspondingFileSignInfoentries ineng/Signing.propswere not added. The Arcade SDK's signing validation correctly flags them as 3rd-party libraries (based on copyright metadata) being signed with the wrong certificate.Changes
Add
FileSignInfoentries withCertificateName="3PartySHA2"for:cc @mitchdenny