Skip to content

Remove temporary nuget.org feed from NuGet.config#14877

Merged
mitchdenny merged 2 commits intorelease/13.2from
fix/remove-nuget-org-feed
Mar 3, 2026
Merged

Remove temporary nuget.org feed from NuGet.config#14877
mitchdenny merged 2 commits intorelease/13.2from
fix/remove-nuget-org-feed

Conversation

@mitchdenny
Copy link
Member

Description

Remove the temporary nuget-org package source and its package source mapping entries (Sigstore, Tuf, NSec.Cryptography, libsodium) from NuGet.config. These packages should be resolved from the normal internal feeds (dotnet-public, dotnet-eng) which already have wildcard * pattern mappings.

The package references in Aspire.Cli.csproj and Directory.Packages.props are unchanged.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Remove the temporary nuget-org package source and its package source
mapping entries (Sigstore, Tuf, NSec.Cryptography, libsodium). These
packages will be resolved from the normal internal feeds (dotnet-public,
dotnet-eng) which have wildcard pattern mappings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 3, 2026 09:34
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14877

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14877"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the temporary nuget-org package source and its associated package source mapping entries from the repo’s root NuGet.config, relying instead on existing internal feeds (dotnet-public, dotnet-eng) to resolve those packages.

Changes:

  • Removed the nuget-org package source entry from NuGet.config.
  • Removed packageSourceMapping rules that explicitly mapped Sigstore/Tuf-related packages to nuget-org.

@JamesNK
Copy link
Member

JamesNK commented Mar 3, 2026

Build is failing because of this change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mitchdenny mitchdenny enabled auto-merge (squash) March 3, 2026 12:10
@mitchdenny mitchdenny disabled auto-merge March 3, 2026 12:39
@mitchdenny mitchdenny merged commit 5338db3 into release/13.2 Mar 3, 2026
380 of 382 checks passed
@mitchdenny mitchdenny deleted the fix/remove-nuget-org-feed branch March 3, 2026 12:39
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Mar 3, 2026
Copilot AI pushed a commit that referenced this pull request Mar 10, 2026
NOTE: Merging to unblock build.

* Remove temporary nuget.org feed from NuGet.config

Remove the temporary nuget-org package source and its package source
mapping entries (Sigstore, Tuf, NSec.Cryptography, libsodium). These
packages will be resolved from the normal internal feeds (dotnet-public,
dotnet-eng) which have wildcard pattern mappings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update Sigstore and Tuf packages to 0.3.0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Mitch Denny <mitch@mitchdeny.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants