Add --disableProductStyleUrl to Azurite emulator args#14855
Merged
eerhardt merged 1 commit intodotnet:release/13.2from Mar 2, 2026
Merged
Add --disableProductStyleUrl to Azurite emulator args#14855eerhardt merged 1 commit intodotnet:release/13.2from
eerhardt merged 1 commit intodotnet:release/13.2from
Conversation
Include --disableProductStyleUrl in Azurite command line when running Azure Storage as an emulator. This is necessary because when a Container resource references the Storage emulator it gets a URL like storage.dev.internal:10000. Using a URL like this conflicts between the Storage SDK and the emulator because the Storage SDK sees port 10000 and uses path-style URLs. But the emulator rejects them because it expects "product-style" URLs. Fix dotnet#14044
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14855Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14855" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Aspire’s Azure Storage emulator (Azurite) container invocation to include --disableProductStyleUrl, aligning Azurite’s URL parsing with the path-style endpoints produced for container-to-container networking (e.g., storage.dev.internal:10000/...) and addressing issue #14044.
Changes:
- Add
--disableProductStyleUrlto the default Azurite argument list used byRunAsEmulator. - Update Azure Storage emulator tests to assert the new argument is included.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.Storage/AzureStorageExtensions.cs | Adds --disableProductStyleUrl to Azurite startup args in RunAsEmulator to avoid product-style URL handling. |
| tests/Aspire.Hosting.Azure.Tests/AzureStorageExtensionsTests.cs | Extends assertions to verify --disableProductStyleUrl is present in evaluated Azurite args. |
Member
|
Should we have a test to confirm that the result is the expected kind of urls? |
Member
Author
Those tests already exist. This doesn't change the URL format at all. This only changes the behavior on the Storage emulator to work with the URLs we give it. |
danegsta
approved these changes
Mar 2, 2026
This was referenced Mar 2, 2026
mitchdenny
pushed a commit
that referenced
this pull request
Mar 5, 2026
Include --disableProductStyleUrl in Azurite command line when running Azure Storage as an emulator. This is necessary because when a Container resource references the Storage emulator it gets a URL like storage.dev.internal:10000. Using a URL like this conflicts between the Storage SDK and the emulator because the Storage SDK sees port 10000 and uses path-style URLs. But the emulator rejects them because it expects "product-style" URLs. Fix #14044
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
Include --disableProductStyleUrl in Azurite command line when running Azure Storage as an emulator. This is necessary because when a Container resource references the Storage emulator it gets a URL like storage.dev.internal:10000. Using a URL like this conflicts between the Storage SDK and the emulator because the Storage SDK sees port 10000 and uses path-style URLs. But the emulator rejects them because it expects "product-style" URLs. Fix #14044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include --disableProductStyleUrl in Azurite command line when running Azure Storage as an emulator. This is necessary because when a Container resource references the Storage emulator it gets a URL like storage.dev.internal:10000. Using a URL like this conflicts between the Storage SDK and the emulator because the Storage SDK sees port 10000 and uses path-style URLs. But the emulator rejects them because it expects "product-style" URLs.
Fix #13811
Fix #14044