Fix JSON-RPC error on disconnect and auto-restart Aspire debug session on AppHost restart by adamint · Pull Request #14548 · dotnet/aspire

adamint · 2026-02-18T18:16:58Z

Description

This PR fixes two issues in the Aspire VS Code extension debug session:

Fixed unexpected JSON-RPC connection lost error on debug session disconnect: When stopping or restarting the Aspire debug session, the CLI process is killed which closes the JSON-RPC connection. Previously this triggered an error notification to the user. Now, stopCli() failures during dispose are caught and logged gracefully, and the dispose() method is guarded against double-disposal to prevent redundant stopCli calls.
Restarting the AppHost resource now restarts the Aspire debug session: Previously, when the AppHost debug session terminated (e.g., due to a resource restart), the Aspire debug session would simply dispose without restarting. Now, if the AppHost terminates and the stop was not user-initiated (i.e., the user didn't explicitly disconnect), the Aspire debug session automatically restarts by launching a new debug session with the same configuration.

(Tested manually. The unexpected JSON-RPC connection lost error was happening on every restart before)

Changes

Added _disposed flag to prevent double-disposal of the debug session
Added _userInitiatedStop flag to distinguish user-initiated stops from AppHost-initiated terminations
Wrapped stopCli() call in error handler since the connection may already be closed during dispose
Removed duplicate stopCli() call from dispose() (already handled by disposables)
When AppHost terminates unexpectedly (not user-initiated), automatically restart the Aspire debug session

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire.dev issue:
    - New issue
- No

…pHost restart

github-actions · 2026-02-18T18:17:31Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14548

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14548"

Copilot

Pull request overview

This PR enhances the Aspire VS Code extension debug session to fix JSON-RPC connection errors during disconnect and to automatically restart debug sessions when the AppHost terminates unexpectedly.

Changes:

Added double-disposal protection with a _disposed flag
Implemented auto-restart functionality for AppHost crashes using a _userInitiatedStop flag to distinguish user-initiated stops from system failures
Improved error handling for stopCli() calls by catching and logging failures gracefully

Copilot · 2026-02-18T18:22:35Z

extension/src/debugger/AspireDebugSession.ts

+          const shouldRestart = !this._userInitiatedStop;
+          const config = this.configuration;


The configuration should be captured before calling dispose() to avoid potential issues. While the configuration is captured into a local variable before dispose is called, the order of operations could be clearer. Consider capturing the configuration at the start of the if block (line 226) before any other operations.

Suggested change

const shouldRestart = !this._userInitiatedStop;

const config = this.configuration;

const config = this.configuration;

const shouldRestart = !this._userInitiatedStop;

extension/src/debugger/AspireDebugSession.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…n on AppHost restart (dotnet#14548) * Fix JSON-RPC error on disconnect and auto-restart debug session on AppHost restart * Update extension/src/debugger/AspireDebugSession.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update extension/src/debugger/AspireDebugSession.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Detect CLI at default install paths when not on PATH (#14545) Check default installation directories (~/.aspire/bin, ~/.dotnet/tools) when the Aspire CLI is not found on the system PATH. If found at a default location, the VS Code setting is auto-updated. If later found on PATH, the setting is cleared. Resolution order: configured custom path > system PATH > default install paths. Fixes #14235 * Fix JSON-RPC error on disconnect and auto-restart Aspire debug session on AppHost restart (#14548) * Fix JSON-RPC error on disconnect and auto-restart debug session on AppHost restart * Update extension/src/debugger/AspireDebugSession.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update extension/src/debugger/AspireDebugSession.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix JSON-RPC error on disconnect and auto-restart debug session on Ap…

00a2756

…pHost restart

adamint marked this pull request as ready for review February 18, 2026 18:17

Copilot AI review requested due to automatic review settings February 18, 2026 18:17

Copilot started reviewing on behalf of adamint February 18, 2026 18:18 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

adamint and others added 2 commits February 18, 2026 12:55

Update extension/src/debugger/AspireDebugSession.ts

558158e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update extension/src/debugger/AspireDebugSession.ts

c900ad6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions bot mentioned this pull request Feb 18, 2026

[pull requests] Review required #13834

Open

mitchdenny approved these changes Feb 24, 2026

View reviewed changes

adamint merged commit 1ffb9bb into dotnet:main Feb 25, 2026
343 checks passed

dotnet-policy-service bot added this to the 13.3 milestone Feb 25, 2026

adamint mentioned this pull request Mar 2, 2026

Cherry-pick VS Code extension fixes from main to release/13.2 #14846

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix JSON-RPC error on disconnect and auto-restart Aspire debug session on AppHost restart#14548

Fix JSON-RPC error on disconnect and auto-restart Aspire debug session on AppHost restart#14548
adamint merged 3 commits intodotnet:mainfrom
adamint:dev/adamint/fix-debug-session-restart

adamint commented Feb 18, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const shouldRestart = !this._userInitiatedStop;
		const config = this.configuration;

Conversation

adamint commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Checklist

Uh oh!

github-actions bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adamint commented Feb 18, 2026 •

edited

Loading

github-actions bot commented Feb 18, 2026 •

edited

Loading