Unquarantine 25 stable tests with zero failures in 159 runs#13874
Unquarantine 25 stable tests with zero failures in 159 runs#13874
Conversation
Co-authored-by: radical <1472+radical@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13874Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13874" |
|
@copilot In the PR description |
Fixed the PR description format - each issue URL is now on a separate line with "Closes" prefix. |
There was a problem hiding this comment.
Pull request overview
This pull request unquarantines 25 previously flaky tests that have demonstrated stability with zero failures across 159 consecutive quarantine runs. The tests span CLI commands, Dashboard components, Azure hosting, JavaScript/Node hosting, testing infrastructure, and core hosting functionality.
Changes:
- Removed
QuarantinedTestattributes from 25 test methods across 10 test files - Tests cover CLI (new/publish/run commands), Dashboard (console logs, browser auth), Azure (Service Bus, Storage emulator), Node.js functionality, testing builders, and distributed application hosting
- Cleaned up some unused
usingdirectives in affected test files
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs | Unquarantined 4 HTTP command tests (issues #9818, #9789, #9772, #9811) |
| tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs | Unquarantined 1 replica command test (issue #9832) |
| tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs | Unquarantined 1 dashboard auth test (issue #8720 via #4651) |
| tests/Aspire.Hosting.Testing.Tests/TestingBuilderTests.cs | Unquarantined 1 launch profile test (issue #9712), reorganized imports |
| tests/Aspire.Hosting.JavaScript.Tests/NodeFunctionalTests.cs | Unquarantined 1 Node.js test (issue #8920) |
| tests/Aspire.Hosting.Azure.Tests/AzureStorageEmulatorFunctionalTests.cs | Unquarantined 1 blob container test (issue #9145), reorganized imports |
| tests/Aspire.Hosting.Azure.Tests/AzureServiceBusExtensionsTests.cs | Unquarantined 1 Service Bus emulator test (issue #12524) |
| tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs | Unquarantined 1 browser auth test (issue #7921) |
| tests/Aspire.Dashboard.Components.Tests/Pages/ConsoleLogsTests.cs | Unquarantined 1 console logs test (issue #12740), removed unused import |
| tests/Aspire.Cli.Tests/Commands/RunCommandTests.cs | Unquarantined 1 run command test (issue #11169), removed unused import |
| tests/Aspire.Cli.Tests/Commands/PublishCommandTests.cs | Unquarantined 1 publish command test (issue #9870), removed unused import |
| tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs | Unquarantined 3 new command tests (issues #10987, #11034, #11172) |
davidfowl
left a comment
There was a problem hiding this comment.
LGTM - unquarantining 25 tests with 0 failures in 159 runs.
|
/unquarantine-test Aspire.Hosting.Tests.DistributedApplicationTests.VerifyExecutableStopStartWorks |
|
@radical ❌ Unquarantine failed. Error: PR #13874 is closed. Can only push to open PRs. See the workflow run for full details. |
Description
Removes quarantine from 25 tests that have demonstrated stability with zero failures across 159 consecutive runs. These tests were previously quarantined due to flakiness but have since stabilized.
Tests unquarantined:
Closes #10987
Closes #11034
Closes #10979
Closes #11172
Closes #11099
Closes #9870
Closes #11169
Closes #12740
Closes #7921
Closes #12524
Closes #9145
Closes #8920
Closes #8870
Closes #9712
Closes #8720
Closes #10086
Closes #8721
Closes #9834
Closes #9832
Closes #9772
Closes #9789
Closes #9811
Closes #9670
Closes #9818
Closes #9800
Checklist
Original prompt
This section details on the original issue you should resolve
<issue_title>[automated] Unquarantine stable tests</issue_title>
<issue_description>
Unquarantine Candidates
The following quarantined tests have been stable with zero failures in their latest 150 runs and are candidates for unquarantining.
Last updated: 2026-01-13 14:54:39 UTC
Instructions for Copilot
Use the
test-disableragent to unquarantine the tests listed below. For each test:[Quarantine]attribute from the test methodFixes <issue-url>line in the PR description for each tracking issue so they are automatically closed on mergeCandidates
Aspire.Cli.Tests.Commands.NewCommandTests.NewCommandDerivesOutputPathFromProjectNameForStarterTemplateAspire.Cli.Tests.Commands.NewCommandTests.NewCommandDoesNotPromptForProjectNameIfSpecifiedOnCommandLineAspire.Cli.Tests.Commands.NewCommandTests.NewCommandDoesNotPromptForTemplateIfSpecifiedOnCommandLineAspire.Cli.Tests.Commands.NewCommandTests.NewCommandDoesNotPromptForTemplateVersionIfSpecifiedOnCommandLineAspire.Cli.Tests.Commands.NewCommandTests.NewCommandInteractiveFlowSmokeTestAspire.Cli.Tests.Commands.PublishCommandTests.PublishCommandSucceedsEndToEndAspire.Cli.Tests.Commands.RunCommandTests.RunCommand_SkipsBuild_WhenExtensionDevKitCapabilityIsAvailableAspire.Dashboard.Components.Tests.Pages.ConsoleLogsTests.ReadingLogs_ErrorDuringRead_SetStatusAndLogAspire.Dashboard.Tests.Integration.Playwright.BrowserTokenAuthenticationTests.BrowserToken_LoginPage_Success_RedirectToResourcesAspire.Hosting.Azure.Tests.AzureServiceBusExtensionsTests.AzureServiceBusEmulatorResourceGeneratesConfigJsonWithCustomizationsAspire.Hosting.Azure.Tests.AzureStorageEmulatorFunctionalTests.VerifyAzureStorageEmulator_blobcontainer_auto_createdAspire.Hosting.JavaScript.Tests.NodeFunctionalTests.VerifyNodeAppWorksAspire.Hosting.JavaScript.Tests.NodeFunctionalTests.VerifyNpmAppWorksAspire.Hosting.Testing.Tests.TestingBuilderTests.CanOverrideLaunchProfileViaArgsAdHocBuilderAspire.Hosting.Tests.DistributedApplicationTests.StartAsync_UnsecuredAllowAnonymous_PassedToDashboardProcessAspire.Hosting.Tests.DistributedApplicationTests.StartResourceForcesStartAspire.Hosting.Tests.DistributedApplicationTests.VerifyExecutableStopStartWorksAspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplicaAspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Success_CalledPerReplicaAspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_CallsGetResponseCallback_AfterSendingRequestAspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingRequestAspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_EnablesCommandUsingCustomUpdateStateCallbackAspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_ResultsInExpectedResultForStatusCodeAspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_UsesEndpointSelector✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.