Fix inaccurate comment about command state update timing#13771
Merged
JamesNK merged 2 commits intojamesnk/with-http-command-flaky-testsfrom Jan 6, 2026
Merged
Fix inaccurate comment about command state update timing#13771JamesNK merged 2 commits intojamesnk/with-http-command-flaky-testsfrom
JamesNK merged 2 commits intojamesnk/with-http-command-flaky-testsfrom
Conversation
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix flaky WithHttpCommand tests based on review feedback
Fix inaccurate comment about command state update timing
Jan 6, 2026
df26a21
into
jamesnk/with-http-command-flaky-tests
2 of 3 checks passed
radical
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Fix WithHttpCommand flaky tests * Clean up * Clean up * Fix inaccurate comment about command state update timing (#13771) Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * Clean up * Restore attributes --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The comment in
WithHttpCommandTests.csincorrectly stated that command state updates happen "asynchronously by a WatchAsync loop". This was inaccurate based on the actual implementation inResourceNotificationService.cs.What changed:
UpdateStatecallback executes synchronously duringPublishUpdateAsynccallThe
UpdateCommandsmethod (line 710 inResourceNotificationService.cs) invokes theUpdateStatecallback synchronously duringPublishUpdateAsync. The wait is necessary only for theOnResourceUpdatedevent to propagate to subscribers.Checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.