Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13065Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13065" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with the Azure provisioning dialog in the dashboard where the resource group combobox wasn't displaying options and the location dropdown was incorrectly disabled.
Key changes:
- Resource group default name is now only set when fetching existing groups fails (not unconditionally)
- Location dropdown is only disabled when an existing resource group has a valid location value
- Minor refactoring to use tuple deconstruction for cleaner code
captainsafia
approved these changes
Nov 21, 2025
5ad7ec3 to
d27aa57
Compare
d27aa57 to
c42d111
Compare
12 tasks
Copilot AI
added a commit
that referenced
this pull request
Nov 21, 2025
- Add assertion for InputType.Choice when subscription ID is not configured - Add assertion for Resource Group having no default value initially - Add test for Resource Group default value behavior during dynamic loading Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
JamesNK
added a commit
that referenced
this pull request
Dec 9, 2025
* Initial plan * Add unit tests for PR #12888 subscription ID input behavior Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> * Add unit tests for PR #13065 changes - Add assertion for InputType.Choice when subscription ID is not configured - Add assertion for Resource Group having no default value initially - Add test for Resource Group default value behavior during dynamic loading Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12979
Fixes some issues with Azure provisioning dialog in the dashboard:
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate