[release/13.0] Refactor overrideStagingHash to overrideStagingFeed and add overrideS…#12825
Merged
joperezr merged 2 commits intorelease/13.0from Nov 7, 2025
Merged
[release/13.0] Refactor overrideStagingHash to overrideStagingFeed and add overrideS…#12825joperezr merged 2 commits intorelease/13.0from
joperezr merged 2 commits intorelease/13.0from
Conversation
…tagingQuality configuration (#12775) * Initial plan * Refactor overrideStagingHash to overrideStagingFeed for full URL override Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com> * Add URL validation for overrideStagingFeed configuration Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com> * Add overrideStagingQuality configuration to control staging channel quality Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12825Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12825" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the staging channel configuration in the Aspire CLI from a hash-based approach to a feed URL-based approach, providing more flexibility for configuring custom staging feeds and their quality settings.
Key Changes:
- Replaced
overrideStagingHashconfiguration withoverrideStagingFeedaccepting full NuGet feed URLs - Added
overrideStagingQualityconfiguration to control package channel quality (Stable, Prerelease, or Both) - Refactored
GetCommitHashForStagingChannel()toGetStagingFeedUrl()with URL validation and fallback to assembly version extraction
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Aspire.Cli/Packaging/PackagingService.cs | Refactored staging channel creation to use full feed URLs instead of commit hashes, added URL validation, and implemented quality override support |
| tests/Aspire.Cli.Tests/Packaging/PackagingServiceTests.cs | Updated existing tests to use feed URLs instead of hashes, added comprehensive test coverage for URL validation, quality override scenarios, and channel ordering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12816 to release/13.0
Customer Impact
Only impacts when staging feature flag is enabled, but allows configurability of both the feed that is used (ability to override it completely) and allows the ability to tune whether it surfaces stable or prerelease builds.
Testing
Manual and one additional unit test.
Risk
Low.
Regression?