Enable container tunnel via environment variable#12816
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12816Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12816" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the EnableAspireContainerTunnel configuration from the DcpPublisher configuration section to an environment variable pattern, making it consistent with other Aspire configuration options.
Key Changes
- Added a new
ASPIRE_ENABLE_CONTAINER_TUNNELconstant toKnownConfigNames.cs - Updated
DcpOptions.csto read the setting from the environment variable instead of theDcpPublisherconfiguration section - Removed the
DcpPublisherconfiguration section from the YARP playground'sappsettings.jsonand added the environment variable tolaunchSettings.json
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/KnownConfigNames.cs | Added EnableContainerTunnel constant for the new environment variable name |
| src/Aspire.Hosting/Dcp/DcpOptions.cs | Changed configuration source from dcpPublisherConfiguration to configuration using the new constant |
| playground/yarp/Yarp.AppHost/appsettings.json | Removed the DcpPublisher configuration section that is no longer needed |
| playground/yarp/Yarp.AppHost/Properties/launchSettings.json | Added ASPIRE_ENABLE_CONTAINER_TUNNEL environment variable to both https and http profiles |
Member
Author
|
/backport to release/13.0 |
Contributor
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19181678977 |
davidfowl
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it a bit less dorky to enable container tunnel