Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/aspire
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.5.0
Choose a base ref
...
head repository: dotnet/aspire
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.5.1
Choose a head ref
  • 16 commits
  • 56 files changed
  • 14 contributors

Commits on Sep 25, 2025

  1. [release/9.5]: Add proper launch profile support to the VS Code exten… 

    …sion (#11617)

* Initial plan

* Add proper launch profile support to the VS Code extension (#11573)

* add vscode-test to gitignore

* change line endings

* update dotnet debugger extension

* fully support launch profiles

* add test profiles to Stress.Empty for manual launch profile support tests

* also validate or provide defaults for launch config on vs code side

* don't parse command line args, apply suggestions

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Adam Ratzman <adam@adamratzman.com>
    @adamint
    Copilot and adamint authored Sep 25, 2025
    Configuration menu
    Copy the full SHA
    65cf003 View commit details
    Browse the repository at this point in the history

  2. [release/9.5] Cherry-pick extension build and sign pipeline setup (#1… 

    …1618)

* Initial plan

* Set up extension build and sign pipeline (#11504)

* first try extension CI

* move above other stages

* install vsce globally before package

* explicitly publish extension

* try add signing

* try #2

* Revert "try #2"

This reverts commit 8006a85.

* try to fix sign

* try with artifacts packages dir property

* remove verification

* clean up

* pr suggestions

* run stages in parallel

* see if this runs in parallel

* add restore back

* rename binlog

* remove extra upload step

* Move building extension to msbuild from the scripts. And always build extension on the internal pipeline

* fix typo

* fix build

* Don't try to parse errors and warnings from yarn/npm invocations. Only use the exit code to determine success or failure

* try publishing vsix

* update paths

* update paths 2

* Revert "update paths 2"

This reverts commit e178308.

* fix path to publish..?

---------

Co-authored-by: Ankit Jain <radical@gmail.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Adam Ratzman <adam@adamratzman.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
    @adamint @radical
    3 people authored Sep 25, 2025
    Configuration menu
    Copy the full SHA
    acf1432 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2025

  1. [release/9.5] Fix globalPackagesFolder path to be platform-agnostic i… 

    …n NuGetConfigMerger (#11626)

* Initial plan

* Fix globalPackagesFolder path to be platform-agnostic

Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
    @github-actions @mitchdenny
    3 people authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    36bb689 View commit details
    Browse the repository at this point in the history

  2. [release/9.5] Fix flashing console windows when Docker processes are … 

    …launched on Windows (#11615)

* Initial plan

* Add CreateNoWindow=true to ProcessUtil.Run to fix flashing console windows on Windows

Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
    @github-actions @captainsafia
    3 people authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    457a727 View commit details
    Browse the repository at this point in the history

  3. [release/9.5] Display help text for GenAI sensitive data when no mess… 

    …ages (#11668)

* Display help text for enabling GenAI sensitive data when there are no messages

* Update

* Handle error spans

---------

Co-authored-by: James Newton-King <james@newtonking.com>
    @github-actions @JamesNK
    github-actions[bot] and JamesNK authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    e44dc82 View commit details
    Browse the repository at this point in the history

  4. [release/9.5] Allow .NET 10 prerelease versions for single-file appho… 

    …st scenarios (#11616)

* Initial plan

* Implement .NET 10 prerelease support for single-file apphost

Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
    @github-actions @mitchdenny
    3 people authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    5744fd6 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2025

  1. [release/9.5] Update Aspire package versions from 9.5.0 to 9.5.1 (#11721 

    )

* Initial plan

* Update Aspire package versions from 9.5.0 to 9.5.1

Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
    @joperezr
    Copilot and joperezr authored Sep 30, 2025
    Configuration menu
    Copy the full SHA
    ec47063 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2025

  1. Refactor Devcontainer port forwarding logic to use a channel for upda… 

    …tes and improve asynchronous processing. (#11730)

- Don't assume we have all of the endpoints up front. Support incrementally updating settings and appending ports to forward.

Fixes #11654

Co-authored-by: David Fowler <davidfowl@gmail.com>
    @github-actions @davidfowl
    github-actions[bot] and davidfowl authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    c11cd25 View commit details
    Browse the repository at this point in the history

  2. Don't require gen_ai.system attribute on span events (#11735) 

    Co-authored-by: James Newton-King <james@newtonking.com>
    @github-actions @JamesNK
    github-actions[bot] and JamesNK authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    90465ad View commit details
    Browse the repository at this point in the history

  3. [release/9.5] Update Microsoft.Extensions.AI packages, use content en… 

    …v var (#11726)

* Initial plan

* Update Microsoft.Extensions.AI packages to 9.9.1 and OpenAI to 2.5.0

Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>

* Update AI integrations to use env var for defaults

* Apply suggestion from @JamesNK

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: James Newton-King <james@newtonking.com>
    @github-actions @JamesNK
    4 people authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    84dc29a View commit details
    Browse the repository at this point in the history

  4. [release/9.5] Fix ParameterProcessor to use ExecutionContextOptions a… 

    …nd skip excluded resources (#11782)

* Initial plan

* Fix ParameterProcessor to use ExecutionContextOptions and skip excluded resources

- Use DistributedApplicationExecutionContextOptions constructor in CollectDependentParameterResourcesAsync
- Copy ServiceProvider from existing execution context when available
- Skip resources excluded from publish using IsExcludedFromPublish()
- Add tests to verify ServiceProvider access and excluded resource filtering

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Simplify: use existing executionContext instead of creating new one

Use the executionContext from constructor instead of creating a new publishExecutionContext

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Update tests/Aspire.Hosting.Tests/Orchestrator/ParameterProcessorTests.cs

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
    @github-actions @davidfowl
    4 people authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    c54a5e4 View commit details
    Browse the repository at this point in the history

  5. [release/9.5] Update retry in Kusto emulator actions to handle any no… 

    …n-permanent error (#11779)

* Extract resilence pipeline and add tests

* Generalize reslience pipeline to handle any non-permanent exception

* Clean up naming

* Fix up names

* Add comment

* Fix namespace

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Matt Kotsenas <matt.kotsenas@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    @github-actions @MattKotsenas
    3 people authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    8d279d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2025

  1. [release/9.5] Fix CommandLineArgsCallbackContext ExecutionContext in … 

    …AzureResourcePreparer and prevent WithVSCodeDebugSupport execution in publish mode (#11788)

* Initial plan

* Fix CommandLineArgsCallbackContext ExecutionContext in AzureResourcePreparer

Set the ExecutionContext property when creating CommandLineArgsCallbackContext in AzureResourcePreparer.GetAzureReferences() to match how EnvironmentCallbackContext is created. This ensures callbacks receive the correct execution context (Publish vs Run mode), preventing WithVSCodeDebugSupport from incorrectly attempting to access ServiceProvider during manifest generation.

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Only execute WithVSCodeDebugSupport in run mode

Add check at method level to only register WithArgs callback when builder.ApplicationBuilder.ExecutionContext.IsRunMode is true. This prevents the callback from being registered during publish mode, avoiding unnecessary callback evaluation during manifest generation.

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Update src/Aspire.Hosting/ResourceBuilderExtensions.cs

* Add tests for WithVSCodeDebugSupport behavior in publish mode

Added tests to verify that WithVSCodeDebugSupport does not add the SupportsDebuggingAnnotation in publish mode, only in run mode. This ensures the debugging annotation is only added when appropriate.

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Address PR feedback: revert formatting and improve test

- Reverted formatting change in ResourceBuilderExtensions.cs (return statement on one line)
- Improved CommandLineArgsCallbackContextHasCorrectExecutionContextDuringPublish test to:
  - Remove unnecessary IsRunMode check in callback
  - Capture ExecutionContext to verify it's set correctly
  - Assert ExecutionContext is not null and in Publish mode

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
    @github-actions @davidfowl
    4 people authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    c04989d View commit details
    Browse the repository at this point in the history

  2. [release/9.5] Fix GenAI visualizer when span is missing peer attribute ( 

    #11765)

* Fix GenAI visualizer when span is missing peer attribute

* Update src/Aspire.Dashboard/Model/GenAI/GenAIVisualizerDialogViewModel.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix build

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    @JamesNK
    JamesNK and Copilot authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    2d6351d View commit details
    Browse the repository at this point in the history

  3. [release/9.5] Support parameter names with dashes resolved from under… 

    …score configuration (#11802)

* Initial plan

* Add parameter name normalization support for dashes to underscores

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Refine parameter normalization to only apply to default configuration keys

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Simplify normalization logic to apply to all configuration keys

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Update src/Aspire.Hosting/ParameterResourceBuilderExtensions.cs

* Make GetParameterValue public and update OpenAI/GitHub Models to use normalization

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Revert public API and duplicate normalization logic in extensions

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Fix ParameterProcessor to skip GenerateParameterDefault exception for non-empty values

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Add tests for GenerateParameterDefault behavior in publish mode

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Make GetParameterValue internal and use it in ParameterProcessor to distinguish configured from generated values

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Apply suggestions from code review

* Replace obsolete parameterResource.Value with GetValueAsync in tests

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Fix GenerateParameterDefault tests to provide ServiceProvider with IConfiguration

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Update src/Aspire.Hosting/Orchestrator/ParameterProcessor.cs

* Update src/Aspire.Hosting/Orchestrator/ParameterProcessor.cs

* Move normalization logic to shared helper in IConfigurationExtensions

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Use extension method syntax for GetValueWithNormalizedKey across all files

Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
    @github-actions
    @davidfowl @captainsafia
    5 people authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    a9d9aea View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2025

  1. [release/9.5] Adapt OpenAI health check based on endpoint configurati… 

    …on (#11792)

* Initial plan

* Fix OpenAI health check to not use status.openai.com for custom endpoints

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Implement adaptive OpenAI health check based on endpoint configuration

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Refactor to use adaptive health check with state tracking on OpenAIResource

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Remove StatusPageHealthCheck.cs as it's been merged into OpenAIHealthCheck

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Simplify to use adaptive OpenAIHealthCheck with 2 cases

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Remove StatusPage health check logic, return healthy for all cases

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Restore OpenAIHealthCheck with CheckStatusPageAsync and CheckEndpointHealthAsync methods

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Make DefaultEndpoint and StatusPage Uri instances static readonly fields

Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com>

* Inline CheckEndpointHealthAsync method

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com>
    @github-actions
    @davidfowl @sebastienros
    6 people authored Oct 3, 2025
    Configuration menu
    Copy the full SHA
    2869435 View commit details
    Browse the repository at this point in the history
Loading