Create workload pack group installers#9514
Conversation
|
|
||
| if (CreateWorkloadPackGroups) | ||
| { | ||
| // TODO: Support passing in data to skip creating pack groups for certain packs (possibly EMSDK, because it's large) |
There was a problem hiding this comment.
Does this mean EMSDK would merge its packs if they used this feature, so for now they just run with CreateWorkloadPackGroups=false?
There was a problem hiding this comment.
I wonder if we could consider a groupable property in the manifest files, or perhaps a groupId that can guide the tools. Another solution eventually would be to allow owners to pass in a set of items that contain pack IDs that can be grouped by the build task
There was a problem hiding this comment.
I was thinking that we would have a parameter which would be a list of packs not to group together. But if we only need it for Emscripten SDK, then maybe that's overkill and we should just use the CreateWorkloadPackGroups=false solution.
| @@ -23,7 +23,7 @@ public void ItAssignsDefaultValues() | |||
| { | |||
There was a problem hiding this comment.
Can we add a test to verify the dependencies in the generated .swr when the packGroupId is passed?
| candle.AddPreprocessorDefinition(PreprocessorDefinitionNames.PackageId, Metadata.Id); | ||
| candle.AddPreprocessorDefinition(PreprocessorDefinitionNames.PackageVersion, $"{Metadata.PackageVersion}"); | ||
| candle.AddPreprocessorDefinition(PreprocessorDefinitionNames.Platform, Platform); | ||
| candle.AddPreprocessorDefinition(PreprocessorDefinitionNames.ProductCode, $"{Guid.NewGuid()}"); |
There was a problem hiding this comment.
Can we fix the GUID here instead? That way anything else that use the variable now and in the future will have the same value. We can just change it to be {Guid.NewGuid():B}
|
We'll probably need @mmitche to help with the merge |
* Remove duplicate PackageReference * Create MSIs for workoad pack groups * Build NuGet wrapper packages for workload pack group MSIs * Generate WorkloadPackGroups.json in manifest MSIs * Add swix authoring for workload pack groups * De-duplicate workload pack group creation * Put braces around ProductCode and UpgradeCode registry values * Write registry keys for pack groups * Fix swix dependencies for pack groups * Use correct GUID format when setting candle variables * Add test for creating pack group dependency in SWR file
* Refactoring workload build tasks (#8645) * Refactoring workload build tasks * Fix source build and some random cleanup * Updating tests, code cleanup * Minor fixes, unit test conversion * Mark tests as Windows only, fix missing content for Helix * Hide WiX and test packages from Solution Explorer * Fix duplicate publish items * Fix link target for helix * Fix link metadata for WiX * Pass ICE suppressions to Light, more cleanup * Fix file extraction for packs, add unit test for template pack MSI * Pass ICE suppressions to Light (#9061) * Create workload pack group installers (#9514) * Remove duplicate PackageReference * Create MSIs for workoad pack groups * Build NuGet wrapper packages for workload pack group MSIs * Generate WorkloadPackGroups.json in manifest MSIs * Add swix authoring for workload pack groups * De-duplicate workload pack group creation * Put braces around ProductCode and UpgradeCode registry values * Write registry keys for pack groups * Fix swix dependencies for pack groups * Use correct GUID format when setting candle variables * Add test for creating pack group dependency in SWR file * Support building with missing workload packs (#9628) * Support building with missing workload packs * Include extracted manifest files in manifest MSI payload nupkg * Fix versioning errors in workloads (#10363) * Fix versioning errors in workloads * Disable TRX tests while reporting to AZDO is broken (#10358) (#10380) Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com> * clean up, api changes Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>
No description provided.