Force import of the "right" version of X509Certificates#9101
Force import of the "right" version of X509Certificates#9101MattGal merged 2 commits intodotnet:mainfrom
Conversation
* Force import of the "right" version so we always restore the version we ask for. * Need to ignore for .proj since these don't have TFMs/restore correctly.
* Force import of the "right" version so we always restore the version we ask for. * Need to ignore for .proj since these don't have TFMs/restore correctly.
* Force import of the "right" version so we always restore the version we ask for. * Need to ignore for .proj since these don't have TFMs/restore correctly.
|
@MattGal just to double-check - should this change be specific to arcade? I am asking because when onboarding Arcade, we ask people to copy this file over so it might not be desirable to have arcade specific things there. |
We need to be CG clean. If people copy and paste things outside the eng/common folder in Arcade, there are numerous examples of things that don't necessarily apply to other repos. If you have an approach that gets a green scan though that you feel is better for that "blind copy/paste" user group, I'm happy to approve that PR. |
I understand that they just shouldn't copy any files and expect to adopt them, but we literally tell them to copy this one when starting a fresh repo:
What if people don't have the I think we could resolve this by putting another |
…ctory. (PR feedback from dotnet#9101 )
Diff: https://github.com/dotnet/arcade/compare/c5dd6a1da2e6d9b3423ab809fcda8af2927a408b..6956787678e164e39ee646448e14353432d83c46 From: dotnet/arcade@c5dd6a1 To: dotnet/arcade@6956787 Commits: - Update dependencies from https://github.com/dotnet/arcade build 20221024.5 (#11399) dotnet/arcade@ec68425 - Move the X509 Certificates version-pinning workaround up to a subdirectory. (PR feedback from dotnet/arcade#9101 ) (#11402) dotnet/arcade@ec89a0f - Add feedback links to all the files (#11317) dotnet/arcade@758b26a - Allow backport workflow to be reusable (#11438) dotnet/arcade@6956787 [[ commit created by automation ]]
Diff: https://github.com/dotnet/arcade/compare/c5dd6a1da2e6d9b3423ab809fcda8af2927a408b..80b6be47e1425ea90c5febffac119250043a0c92 From: dotnet/arcade@c5dd6a1 To: dotnet/arcade@80b6be4 Commits: - Update dependencies from https://github.com/dotnet/arcade build 20221024.5 (#11399) dotnet/arcade@ec68425 - Move the X509 Certificates version-pinning workaround up to a subdirectory. (PR feedback from dotnet/arcade#9101 ) (#11402) dotnet/arcade@ec89a0f - Add feedback links to all the files (#11317) dotnet/arcade@758b26a - Allow backport workflow to be reusable (#11438) dotnet/arcade@6956787 - [main] Update dependencies from dotnet/roslyn (#11430) dotnet/arcade@c1a5de6 - Fix IMAGE_DATA_DIRECTORY structure documentation url in comment (#11443) dotnet/arcade@bbe32bd - Suppress a couple warnings coming from automated scans (#11461) dotnet/arcade@f9e265e - Update dependencies from https://github.com/dotnet/arcade build 20221028.1 (#11470) dotnet/arcade@d4e96f1 - Add scorecards for 2022-10-26 (#11448) dotnet/arcade@7607f96 - Add One-pager for agentless helix (#11316) dotnet/arcade@5be5561 - Refactor backport workflow, make it reusable (#11469) dotnet/arcade@a1a050e - Add release notes to arcade issue template (#11444) dotnet/arcade@d17c6da - Fix the target framework in the msi.proj now that net5.0 is unsupported by the sdk (#11502) dotnet/arcade@cabdcb2 - Update dependencies from https://github.com/dotnet/arcade build 20221102.1 (#11497) dotnet/arcade@ee62d65 - Update default msbuild for sdk tasks (#11508) dotnet/arcade@80b6be4 [[ commit created by automation ]]
(we were restoring multiple before and this is undesirable for static analysis)
To double check: