Skip to content

Remove disableComponentGovernance parameter from jobs.yml#8471

Merged
3 commits merged intodotnet:mainfrom
riarenas:riarenas/remove-disableCG-jobs-yml
Feb 14, 2022
Merged

Remove disableComponentGovernance parameter from jobs.yml#8471
3 commits merged intodotnet:mainfrom
riarenas:riarenas/remove-disableCG-jobs-yml

Conversation

@riarenas
Copy link
Contributor

#8470

We don't really want to encourage disabling this all throughout a set of jobs, and it's causing issues with disabling it in individual jobs anyways.

To double check:

@riarenas riarenas requested review from Chrisboh and mmitche February 14, 2022 17:32
@riarenas
Copy link
Contributor Author

Currently running a test for this in this build to verify that the property still gets passed through to the inner jobs that request it:

https://dev.azure.com/dnceng/internal/_build/results?buildId=1611693&view=results

mmitche
mmitche previously approved these changes Feb 14, 2022
@mmitche
Copy link
Member

mmitche commented Feb 14, 2022

@riarenas This might be worth a backport to 3.1/5.0/6.0 too when after verifying in main.

@riarenas
Copy link
Contributor Author

@mmitche Yep I plan to backport wherever it's needed. I'll need another approval as I had previously left in a change only for testing.

@riarenas
Copy link
Contributor Author

Test works: https://dev.azure.com/dnceng/internal/_build/results?buildId=1611693&view=results the linux leg (which I enabled for this test) still has cg, but it's gone from windows as the parameter was forwarded.

@riarenas riarenas added the auto-merge Automatically merge PR once CI passes. label Feb 14, 2022
@ghost
Copy link

ghost commented Feb 14, 2022

Hello @riarenas!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 64a7268 into dotnet:main Feb 14, 2022
riarenas added a commit to riarenas/arcade that referenced this pull request Feb 14, 2022
* Remove disableComponentGovernance parameter from jobs.yml

* Test disabling cg in the windows leg

* remove testing change
riarenas added a commit to riarenas/arcade that referenced this pull request Feb 22, 2022
* Remove disableComponentGovernance parameter from jobs.yml
riarenas added a commit to riarenas/arcade that referenced this pull request Feb 22, 2022
* Remove disableComponentGovernance parameter from jobs.yml
riarenas added a commit to riarenas/arcade that referenced this pull request Feb 22, 2022
* Remove disableComponentGovernance parameter from jobs.yml
mmitche pushed a commit that referenced this pull request Feb 22, 2022
)

* Remove disableComponentGovernance parameter from jobs.yml
mmitche pushed a commit that referenced this pull request Feb 22, 2022
)

* Remove disableComponentGovernance parameter from jobs.yml
mmitche pushed a commit that referenced this pull request Feb 22, 2022
)

* Remove disableComponentGovernance parameter from jobs.yml
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Automatically merge PR once CI passes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants