Change code-mirror to use Ubuntu build agent#8449
Merged
Conversation
The idea here is to improve throughput of code-mirror runs by switching from a Windows-based agent to a Linux-based agent. Linux-based agents provision faster. So this should reduce the overall time for a GitHub commit to reach the AzDO repo. I haven't tested this change since I don't have the necessary permissions or git understanding to fix something that might get screwed up. Fixes dotnet/core-eng#15402
Member
|
This won't work without additional changes. The script itself needs to be converted over to core. IIRC the powershell v1 task is classic powershell only, |
Member
Member
|
@mthalman addition changes made, test build works: https://dev.azure.com/dnceng/internal/_build/results?buildId=1603308&view=results |
RikkiGibson
approved these changes
Feb 10, 2022
| steps: | ||
| - task: PowerShell@1 | ||
| - powershell: | | ||
| $gitHubRepo = "${{ parameters.GithubRepo }}" |
Member
There was a problem hiding this comment.
Checking my grasp on AzDO YAML... this is changing from reading a variable during script execution, to doing a template substitution before script execution begins, right?
Member
There was a problem hiding this comment.
Yeah. This is the recommended methodology for parameters.
Member
Member
Author
|
Looks like this borked the mirror: https://dev.azure.com/dnceng/internal/_build/results?buildId=1612783&view=results I'm going to revert this for tonight and we can take a look at the failure in the morning |
1 task
ghost
pushed a commit
that referenced
this pull request
Feb 15, 2022
mmitche
added a commit
to mmitche/arcade
that referenced
this pull request
Mar 24, 2022
* Change code-mirror to use Ubuntu build agent The idea here is to improve throughput of code-mirror runs by switching from a Windows-based agent to a Linux-based agent. Linux-based agents provision faster. So this should reduce the overall time for a GitHub commit to reach the AzDO repo. I haven't tested this change since I don't have the necessary permissions or git understanding to fix something that might get screwed up. Fixes dotnet/core-eng#15402 * Update PowerShell tasks to use PowerShell Core * Test test * Add parameters * Add parameters * Add parameters * Add working directory to second powershell command Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
mmitche
added a commit
to mmitche/arcade
that referenced
this pull request
Mar 24, 2022
* Change code-mirror to use Ubuntu build agent The idea here is to improve throughput of code-mirror runs by switching from a Windows-based agent to a Linux-based agent. Linux-based agents provision faster. So this should reduce the overall time for a GitHub commit to reach the AzDO repo. I haven't tested this change since I don't have the necessary permissions or git understanding to fix something that might get screwed up. Fixes dotnet/core-eng#15402 * Update PowerShell tasks to use PowerShell Core Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
mmitche
added a commit
that referenced
this pull request
Mar 25, 2022
* Change code-mirror to use Ubuntu build agent The idea here is to improve throughput of code-mirror runs by switching from a Windows-based agent to a Linux-based agent. Linux-based agents provision faster. So this should reduce the overall time for a GitHub commit to reach the AzDO repo. I haven't tested this change since I don't have the necessary permissions or git understanding to fix something that might get screwed up. Fixes dotnet/core-eng#15402 * Update PowerShell tasks to use PowerShell Core Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: Matt Thalman <mthalman@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to improve throughput of code-mirror runs by switching from a Windows-based agent to a Linux-based agent. Linux-based agents provision faster. So this should reduce the overall time for a GitHub commit to reach the AzDO repo.
I haven't tested this change since I don't have the necessary permissions or git understanding to fix something that might get screwed up.
Fixes https://github.com/dotnet/core-eng/issues/15402
To double check: