Merged
Conversation
Member
Author
|
FYI @steveisok This should solve the issue for EMSDK |
Member
|
Thanks @joeloff for figuring this out quickly! |
dsplaisted
previously approved these changes
Feb 3, 2022
Member
Author
|
@chcosta adding you since I need someone from eng to approve before I can merge. |
chcosta
previously approved these changes
Feb 3, 2022
Member
chcosta
left a comment
There was a problem hiding this comment.
I have no opinion on these changes so... LGTM
Member
Author
|
Help me @mmitche you're my only hope I thought anyone from eng would unblock the merge, but I guess not since this is 6.0 |
mmitche
reviewed
Feb 3, 2022
src/Microsoft.DotNet.Build.Tasks.Workloads/src/GenerateWorkloadMsis.cs
Outdated
Show resolved
Hide resolved
mmitche
approved these changes
Feb 3, 2022
Member
Author
|
@mmitche could you please merge this? |
joeloff
added a commit
to joeloff/arcade
that referenced
this pull request
Feb 4, 2022
* Dedupe workload packs * Replace HashSet with List
Merged
joeloff
added a commit
that referenced
this pull request
Feb 7, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduping packs based on ID and version. Since WorkloadPacks don't implement GetHashCode, Distinct() fails to dedupe properly. Duplicate packs causes issues when trying to compile/link the same pack in parallel and can also create multiple PackageCodes for the same MSI leading to other problems when the MSIs are actually installed.