Skip to content

[release/6.0] Enable CG detection in the job templates (#8376)#8403

Merged
mmitche merged 2 commits intodotnet:release/6.0from
mmitche:cg-for-6.0
Feb 1, 2022
Merged

[release/6.0] Enable CG detection in the job templates (#8376)#8403
mmitche merged 2 commits intodotnet:release/6.0from
mmitche:cg-for-6.0

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Jan 27, 2022

Remove the explicit injection in the arcade pipeline

To double check:

Remove the explicit injection in the arcade pipeline
@mmitche
Copy link
Member Author

mmitche commented Jan 27, 2022

So far no major issues rolling this out in main.

riarenas
riarenas previously approved these changes Jan 27, 2022
@mmitche
Copy link
Member Author

mmitche commented Jan 27, 2022

@agocke
Copy link
Member

agocke commented Jan 27, 2022

@mmitche any idea what's going wrong here? I have no idea how to debug this.

@agocke
Copy link
Member

agocke commented Jan 28, 2022

Nvm apparently Michal figured it out

@mmitche
Copy link
Member Author

mmitche commented Feb 1, 2022

@riarenas Can I get final approval here?

@mmitche
Copy link
Member Author

mmitche commented Feb 1, 2022

or @MattGal I ported the continueOnError to 6.0

Copy link
Contributor

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, weird that it got reset.

@mmitche mmitche merged commit 22ebdfe into dotnet:release/6.0 Feb 1, 2022
mmitche added a commit to mmitche/arcade that referenced this pull request Feb 4, 2022
* Enable CG detection in the job templates (dotnet#8376)

Remove the explicit injection in the arcade pipeline

* Continue on error for CG
mmitche added a commit that referenced this pull request Feb 5, 2022
* Enable CG detection in the job templates (#8376)

Remove the explicit injection in the arcade pipeline

* Continue on error for CG
@mmitche mmitche deleted the cg-for-6.0 branch February 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants