Move VerifyClosure tasks into M.D.PackageTesting#7692
Merged
ViktorHofer merged 1 commit intodotnet:mainfrom Aug 2, 2021
Merged
Move VerifyClosure tasks into M.D.PackageTesting#7692ViktorHofer merged 1 commit intodotnet:mainfrom
ViktorHofer merged 1 commit intodotnet:mainfrom
Conversation
926af47 to
66e4867
Compare
ViktorHofer
added a commit
to ViktorHofer/runtime
that referenced
this pull request
Aug 1, 2021
Depends on dotnet/arcade#7692 Removing the dependency on the Packaging assembly in favor of the PackageTesting assembly which now contains the VerifyClosure and VerifyTypes tasks that are required for package testing. Also removing some obsolete properties and files.
66e4867 to
2833628
Compare
9b765fa to
b0b4c0a
Compare
As we plan to deprecate the M.D.B.Tasks.Packaging project in the future, moving the tasks into the PackageTesting project. Fixes dotnet#7474
b0b4c0a to
2b02594
Compare
ViktorHofer
commented
Aug 2, 2021
| <PackageReference Include="NuGet.Frameworks" Version="$(NuGetVersion)" /> | ||
| <PackageReference Include="NuGet.Packaging" Version="$(NuGetVersion)" /> | ||
| <!-- Remove when targeting >= net5.0. --> | ||
| <PackageReference Include="System.Reflection.Metadata" Version="5.0.0" /> |
Member
Author
There was a problem hiding this comment.
This PackageReference is required to avoid a conflict in ResolveAssemblyReference where RAR can't decide which System.Reflection.Metadata assembly to choose.
akoeplinger
approved these changes
Aug 2, 2021
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
Aug 2, 2021
* React to Verify* task PackageTesting change Depends on dotnet/arcade#7692 Removing the dependency on the Packaging assembly in favor of the PackageTesting assembly which now contains the VerifyClosure and VerifyTypes tasks that are required for package testing. Also removing some obsolete properties and files.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we plan to deprecate the M.D.B.Tasks.Packaging project in the future,
moving the tasks into the PackageTesting project. This removes the dependency on the Packaging assembly in the package testing infrastructure in dotnet/runtime.
Fixes #7474
To double check: