Record pipelineReference in spawned TestRuns#7209
Merged
ChadNedzlek merged 2 commits intodotnet:mainfrom Apr 9, 2021
Merged
Conversation
07c56db to
61b4cc2
Compare
garath
reviewed
Apr 8, 2021
garath
reviewed
Apr 8, 2021
| [Required] | ||
| public string TestRunName { get; set; } | ||
|
|
||
| public string JobName { get; set; } |
Contributor
Author
There was a problem hiding this comment.
They are parameters on the task. I didn't set them because I defaulted them all to the environment values. When we do the weird "start a run in some other job", we'll need to set these to make them "line up". But for now they are always the same, so it's ok to read the environment variables.
Contributor
Author
There was a problem hiding this comment.
@alexperovich might have an opinion about this (BuildId, from the base class, reads the environment, so I figured it was ok)
garath
approved these changes
Apr 8, 2021
alexperovich
approved these changes
Apr 8, 2021
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to do better correlation in analysis, we need the ability to correlate
tests to which parts of the build they came form. The build in reporting sets these
but the helix reporter does not, so record them