Small cleanup and send aka.ms link prefix for stable#7203
Merged
mmitche merged 1 commit intodotnet:mainfrom Apr 7, 2021
Merged
Small cleanup and send aka.ms link prefix for stable#7203mmitche merged 1 commit intodotnet:mainfrom
mmitche merged 1 commit intodotnet:mainfrom
Conversation
Stable builds were not sending the aka.ms link prefix. I think this is safe, now that all the blobs are unique, and typically these are internal anyway. Also, combine NonStableInternalFeeds and NonStablePublicFeeds into one method, as they were basically identical, aside from one tweak around symbols
epananth
approved these changes
Apr 7, 2021
2 tasks
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
Stable builds were not sending the aka.ms link prefix. I think this is safe, now that all the blobs are unique, and typically these are internal anyway. Also, combine NonStableInternalFeeds and NonStablePublicFeeds into one method, as they were basically identical, aside from one tweak around symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stable builds were not sending the aka.ms link prefix. I think this is safe, now that all the blobs are unique, and typically these are internal anyway.
Also, combine NonStableInternalFeeds and NonStablePublicFeeds into one method, as they were basically identical, aside from one tweak around symbols