Switch argument order in SkipOnPlatformAttribute#7192
Merged
akoeplinger merged 1 commit intodotnet:mainfrom Apr 6, 2021
Merged
Switch argument order in SkipOnPlatformAttribute#7192akoeplinger merged 1 commit intodotnet:mainfrom
akoeplinger merged 1 commit intodotnet:mainfrom
Conversation
While looking at doing the conversion in dotnet/runtime after dotnet#7184 I noticed that having the reason argument reads weird, it's better to have the platform as the first argument so it reads more like a sentence. E.g. instead of ```csharp [SkipOnPlatform("System.Net.Security is not supported on this platform.", TestPlatforms.Browser)] ``` we have ```csharp [SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on this platform.")] ``` Also allow multiple attributes since the skip reason can be quite different between platforms.
safern
approved these changes
Apr 6, 2021
akoeplinger
added a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
While looking at doing the conversion in dotnet/runtime after dotnet#7184 I noticed that having the reason argument reads weird, it's better to have the platform as the first argument so it reads more like a sentence. E.g. instead of ```csharp [SkipOnPlatform("System.Net.Security is not supported on this platform.", TestPlatforms.Browser)] ``` we have ```csharp [SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on this platform.")] ``` Also allow multiple attributes since the skip reason can be quite different between platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at doing the conversion in dotnet/runtime after #7184 I noticed that having the
reasonargument as the last argument reads weird, it's better to have the platform as the first argument so it reads more like a sentence.E.g. instead of
we have
Also allow multiple attributes since the skip reason can be quite different between platforms.