Add support for LangIDOnPath templates to LocProject.json generation#7187
Merged
jonfortescue merged 1 commit intodotnet:mainfrom Apr 19, 2021
Merged
Add support for LangIDOnPath templates to LocProject.json generation#7187jonfortescue merged 1 commit intodotnet:mainfrom
jonfortescue merged 1 commit intodotnet:mainfrom
Conversation
ChadNedzlek
approved these changes
Apr 8, 2021
Contributor
ChadNedzlek
left a comment
There was a problem hiding this comment.
I assume we don't control the "LandIDOnName" value, right? That 'D', REALLY needs to be lowercased. It took me like a solid minute of brain melting before I figured out what it was saying. :-)
Contributor
Author
|
@ChadNedzlek forgot to reply to this but indeed we do not haha. Going to wait until I'm off FR to merge this so I can babysit it as it rolls out. |
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
jonfortescue
added a commit
to jonfortescue/arcade
that referenced
this pull request
Apr 22, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dotnet/core-eng#12673.
Some repos (like winforms) use templates that have langcodes as directories (e.g.
en\strings.json,fr\string.json). This PR adds support for that.To double check: