Merged
Conversation
ericstj
reviewed
Apr 1, 2021
Anipik
reviewed
Apr 1, 2021
ericstj
reviewed
Apr 6, 2021
ericstj
approved these changes
Apr 6, 2021
Member
ericstj
left a comment
There was a problem hiding this comment.
LGTM, pending usage clarification suggestions
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
ericstj
approved these changes
Apr 7, 2021
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
* Added Option for SetNames * Apply suggestions from code review Co-authored-by: Eric StJohn <ericstj@microsoft.com> * Fixed description in Options to align with readme Co-authored-by: Eric StJohn <ericstj@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello its me again
In this Commit I simply added options for each set name. I also thought about committing changes for all the Info-Diagnostics but I didnt want to break anything so I did not.
@Anipik @safern @ericstj