[AsmDiff]Added Localized Content for markdown header and Language Option#7173
Conversation
|
|
| @@ -0,0 +1,91 @@ | |||
| //------------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
We don't typically check these in, we have a generator that runs during the build to produce them. You can omit this file and set GenerateSource: https://github.com/dotnet/arcade/blob/6cc4c1e9e23d5e65e88a8a57216b3d91e9b3d8db/Documentation/ArcadeSdk.md#generateresxsource-bool
|
Very cool, thank you for the contribution! I made a couple notes on how to proceed. I also went ahead and implemented the suggestions if you'd like to take them: ericstj@fd5f861 |
|
I added your changes to this PR, actually I've never even heard of Xliff before. Thank you. |
This happens to be the infrastructure we use throughout dotnet repos for localization. You can learn more about it here: https://github.com/dotnet/xliff-tasks |
…ion (dotnet#7173) * Added Localized Content for markdown header and Language Option * Applied changes from ericstj@fd5f861
Hello its me from #7164
Adding
<StrongNameKeyId>Open</StrongNameKeyId>did fix the problems with signing, thank you.I tried setting the language for the generated comments in the ResourceDesigner, but could not find a way without installing and changing the language of VisualStudio. Maybe you could run the generation once and commit the new output if you want it in english.
@Anipik @safern @ericstj