Build tasks for optional workload generation/authoring#7169
Build tasks for optional workload generation/authoring#7169joeloff merged 2 commits intodotnet:mainfrom
Conversation
|
@mmitche any suggestions who from the Arcade side I can add? @jonathanpeppers and @pranavkm as an FYI. |
|
@chcosta Is good at these types of reviews. |
|
Ack. There's a lot of changes. I'll try to look today, but more likely have to set aside time tomorrow. |
|
Thanks @chcosta |
|
Sorry, I didn't get you this today. 🙁 |
chcosta
left a comment
There was a problem hiding this comment.
Seems fine, though admittedly, my eyes glazed over at some of the nuance of msi-ness that I haven't looked at for quite a while now. Left a couple of minor bits of feedback.
Not having tests, make it hard for me to do any validation apart from staring at the code on screen. If you want a more detailed review of the msi / setup stuff, you might ask Nikola, but in general this looks reasonable.
src/Microsoft.DotNet.Build.Tasks.Workloads/src/EmbeddedTemplates.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj
Outdated
Show resolved
Hide resolved
| <Compile Include="..\..\Common\Internal\BuildTask.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net472'"> |
* Build tasks for optional workload generation/authoring * PR feedback
|
Can we try to share some of the work here with Microsoft.DotNet.Build.Tasks.Installers? Or is that not possible with the workload design? |
|
@jkoritzinsky such as sharing code? |
|
Yes, that's what I was thinking. |
|
Ah, the installers for the workloads are very specific and a lot of the tasks focus on generating the corresponding authoring for Visual Studio. |
|
Ah that makes sense. Is there any way we can make part of the UX of the packages similar so that (for example) moving dotnet/windowsdesktop to use it would be as simple as changing a project reference? At least for the simple cases of the Installers package. Or would building the workloads infra on top of the installers package infra make any sense? If that’s not possible it’s ok, but I’d like to share/layer if possible. If not with the Installers package than layer on top of the Shared Framework SDK. |
Initial set of build tasks to unblock workload authoring so consumers can evaluate and see whether it fits into their workflow.
Tasks include
Tests are being worked on.