Fix GenerateBuildManifest publish version parsing#7167
Conversation
The `<GenerateBuildManifest/>` task was erroring every time the `PublishingVersion` input parameter was used. The `Enum.TryParse` success check has been fixed to prevent this. Additionally, some unused parameters have been removed from the task.
|
@mmitche I'm hoping to use this task as part of xamarin build asset publishing. The alternative tasks that generate a manifest require that the assets be pushed to azure artifacts or blob storage as well, which we're already doing elsewhere in our builds. I did see that this task was removed and restored somewhat recently though, so I wanted to make sure it would be ok to use it. |
Publishing will not work without the push to azure artifacts. That pushes the artifacts that should be published to known locations, which publishing then picks up. The goal of arcade's publishing is that nothing leaves the build and goes elsewhere until there is an explicit assignment to a channel. So we never publish to blob storage or feeds until we want to assign to a channel, which defines intent. This is how we avoid from accidental publishing of internal fixes to public feeds, for instance. The build simply doesn't do any publishing except to artifact storage local to the build. You can use GenerateBuildManifest, but it would only be to notify BAR of the new build. Dependencies could still flow (when assigning to a channel you can skip publishing), but arcade couldn't handle publishing. |
Chatted offline about this a bit, and this usage will serve our needs for the short term at least. |
|
I think there was an outage that caused the Linux test timeouts above. I don't have permission to re-run these jobs but I think this should be ready to go, the new test is passing on other environments. |
The `<GenerateBuildManifest/>` task was erroring every time the `PublishingVersion` input parameter was used. The `Enum.TryParse` success check has been fixed to prevent this. Additionally, some unused parameters have been removed from the task.
The
<GenerateBuildManifest/>task was erroring every time thePublishingVersioninput parameter was used. TheEnum.TryParsesuccess check has been fixed to prevent this. Additionally, some unused
parameters have been removed from the task.
To double check: