Update codeanalysis for genfacades to support new language features #6971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anipik
approved these changes
Feb 19, 2021
Member
|
Thanks, @safern. |
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
…otnet#6971) * Update codeanalysis for genfacades to support new language features * Fix source build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if someone tries to use C# 9.0 language features genfacades doesn't parse the syntax tree correctly and could lead to problems, i.e, when adding an attribute to a local function in
PriorityQueueit causes the parent ofPriorityQueue.UnorderedItemsCollectionto be aCompilationUnitSyntaxinstead of aClassDeclarationSyntax, causing:I tested this on dotnet/runtime and apparently now MSBuild loads tasks in it's own AssemblyLoadContext so now we don't have the restriction of matching the roslyn version that MSBuild depends on. This was fixed on: dotnet/msbuild#4916
cc: @ericstj @stephentoub @Anipik