netcoreapp3.1 all the things#6891
Conversation
chcosta
left a comment
There was a problem hiding this comment.
I'm glad this is happening, also... it's scary because these types of changes never "just work". :/ Hope this one goes well!
| local logger_path="$toolset_dir/$_InitializeBuildToolFramework/Microsoft.DotNet.ArcadeLogging.dll" | ||
| if [[ ! -f $logger_path ]]; then | ||
| logger_path="$toolset_dir/$_InitializeBuildToolFramework/Microsoft.DotNet.Arcade.Sdk.dll" | ||
| # new scripts need to work with old packages, so we need to look for the old names/versions |
There was a problem hiding this comment.
I think I'm missing context here, why do new scripts need to work with old packages? what's an example?
There was a problem hiding this comment.
This pr build. Its building with old arcade that has the dll in netcoreapp2.1, but once things get published it will be using the arcade with the dll in netcoreapp3.1
There was a problem hiding this comment.
Is that the only example? Seems slightly odd to code around that and open up this odd behavior for a one time thing.
There was a problem hiding this comment.
its really the whole arcade build, it doesn't work without this.
There was a problem hiding this comment.
I don't follow. Aren't we just talking about finding the logger here?
Also, is the logging code ever in netcoreapp3.1\Arcade.sdk.dll? It has already moved to Microsoft.DotNet.ArcadeLogging.dll
There was a problem hiding this comment.
Yes, we are talking about finding the logger. The arcade build itself uses version n-1 packages, with version n scripts, so the scripts have to be able to use the old names.
There was a problem hiding this comment.
Chatted with Alex and we agreed that this could get cleaned up post-merge. Thanks Alex!
| if [[ ! -f $logger_path ]]; then | ||
| logger_path="$toolset_dir/$_InitializeBuildToolFramework/Microsoft.DotNet.Arcade.Sdk.dll" | ||
| # new scripts need to work with old packages, so we need to look for the old names/versions | ||
| local selectedPath= |
There was a problem hiding this comment.
I thought there was a convention at one point (or an attempt at one), and this would be selected_path.
nit: My preference would be selected_logger_path for clarity
There was a problem hiding this comment.
will remove this when I clean up post merge.
|
It seems like this commit broke dotnet/runtime build due to more details at dotnet/runtime#48054 |
@alexperovich is aware, will synch with him at FR standup shortly. |
|
This isn't a bug with arcade, we knew about this and runtime has to react to the change. The runtime repo has a hardcoded dependency on netcoreapp2.1 where they manually reference the dll for that task. That reference needs to be updated to netcoreapp3.1, or preferably completely stop manually referencing the dll. |
|
@marek-safar I emailed the Partner's alias about this on Monday and @ViktorHofer said he would take care of this issue for dotnet/runtime. |
|
Already took care of it and just waiting for the build to progress: dotnet/runtime#48054. |
* netcoreapp3.1 all the things * Fix logger paths * Put signtool tests stuff back * Fix the tests
|
Is there any new plans to update all the tasks again to target .NET 6 since it is a new LTS release for arcade? |
#6745