Skip to content

Setting enableSourceBuild #6871

Merged
MattGal merged 1 commit intodotnet:masterfrom
MattGal:arcade-6845
Jan 29, 2021
Merged

Setting enableSourceBuild #6871
MattGal merged 1 commit intodotnet:masterfrom
MattGal:arcade-6845

Conversation

@MattGal
Copy link
Copy Markdown
Member

@MattGal MattGal commented Jan 28, 2021

(see context in #6845)

@dagood
Copy link
Copy Markdown
Member

dagood commented Jan 29, 2021

The current error fatal: empty ident name (for <vsts_azpcontainer@5486fd8241d9.(none)>) not allowed is a few things coming together:

  • dotnet/arcade has bad line endings in a few files, so even in a fresh clone in CI, some changes show up.
  • The source-build tooling creates an extra clone of the repo in artifacts/ to run the build in. When there are changes in the outer repo, the source-build tooling creates a Git stash to transfer the changes into the inner repo.
  • Containers don't have a Git author set up, and making a stash requires that, so we hit the error.

#6874 will unblock this for now, and eventually an auto-update will get the tooling change in case something weird like this happens again (or in another repo).

@dagood
Copy link
Copy Markdown
Member

dagood commented Jan 29, 2021

Nice, green. I'd recommend doing a mock official build too, to make sure the source-build intermediate package can flow as expected.

@MattGal MattGal marked this pull request as ready for review January 29, 2021 18:56
@MattGal
Copy link
Copy Markdown
Member Author

MattGal commented Jan 29, 2021

Tried with the official build pipeline, green too so merging:
https://dnceng.visualstudio.com/internal/_build/results?buildId=971631&view=logs&j=1217766f-bb40-52a2-b66d-f8ecc3a6dc68

@MattGal MattGal merged commit bed0b91 into dotnet:master Jan 29, 2021
akoeplinger pushed a commit to akoeplinger/arcade that referenced this pull request Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants