Refactoring PushToAzureDevOpsArtifacts tests#6672
Merged
missymessa merged 47 commits intomasterfrom Dec 30, 2020
Merged
Conversation
missymessa
commented
Dec 9, 2020
missymessa
commented
Dec 9, 2020
missymessa
commented
Dec 9, 2020
missymessa
commented
Dec 10, 2020
missymessa
commented
Dec 10, 2020
missymessa
commented
Dec 10, 2020
missymessa
commented
Dec 10, 2020
missymessa
commented
Dec 10, 2020
missymessa
commented
Dec 10, 2020
ChadNedzlek
reviewed
Dec 10, 2020
ChadNedzlek
reviewed
Dec 10, 2020
ChadNedzlek
reviewed
Dec 10, 2020
ChadNedzlek
reviewed
Dec 10, 2020
…ct away some of the DI
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
* oh boy we're doing some testing * Set up fake filesystem, add test for PublishFlatContainer * SigningInformation test * remove net test sdk * re-rename for merge * Changes resulting from merge to master * smoe more updates * re-add generatebuildmanifest.proj * quick fixups * Some refactoring based on discussions of how to implement this better :) * Got the abstract class in a good state; started refactoring classes so they can be dependency injected * Tests work now * Pulled Nunit stuff out of the test project since we're not using it * missing namespaces were causing the build to fail * Added more DI to the places that needed it. Fixed a couple of failing tests * Injecting the TaskLoggingHelper into it's dependencies instead of manually passing it into methods * Missed a couple places that needed the logger DI * commenting all the things * Tests to ensure DI was properly wired up for the refactored tasks * Tests to ensure top-level dependencies are configured * Fixing failing tests * Attempting to fix Nuget error * trying to suss out the nuget error * trying to suss out the nuget error * putting everything back the way it was * checking to see if I can't reference the VersionTools.Task project for tests * Let's see if this fixed the tests * skip signing of testing project * Omitting more test projects from being signed * reverting changes to skip signing on test projects. Need a different solution * Need to set up FluentAssertions to be signed by the third party cert * Does Helix like strings that were once XDocuments better? * Figure out why the task is failing on Helix * Changed save options for ToString-ing XML to improve test reliability * let's see if we can get error messages out of the Build Engine * adding some logging to figure out why PackageArtifactModelFactory is failing * Making the file path strings OS-agnostic * Consolidated expected content builders into reusable functionality * Created factory for VersionsRepoUpdater classes, attempting to abstract away some of the DI * clean up random stuff that was added to the csproj files Co-authored-by: Jon Fortescue <jofortes@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up where Jon left off here: https://github.com/dotnet/arcade/pull/6611/files
Things to note: