Skip to content

Refactoring PushToAzureDevOpsArtifacts tests#6672

Merged
missymessa merged 47 commits intomasterfrom
missymessa-6344
Dec 30, 2020
Merged

Refactoring PushToAzureDevOpsArtifacts tests#6672
missymessa merged 47 commits intomasterfrom
missymessa-6344

Conversation

@missymessa
Copy link
Copy Markdown
Member

Picking up where Jon left off here: https://github.com/dotnet/arcade/pull/6611/files

Things to note:

  • Attempting to implement DI in an abstract base class to apply to all MSBuild Task classes.
  • Going to try applying the rest of the previous PR's feedback to this PR eventually
  • See the rest of my comments in the PR, but happy to take feedback on anything you see :)

Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/BuildModelFactory.cs
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/BuildModelFactory.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/MSBuildTaskBase.cs Outdated
Comment thread src/Microsoft.DotNet.VersionTools/lib/src/Automation/NupkgInfo.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/BlobArtifactModelFactory.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PushToAzureDevOpsArtifactsTests.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PushToAzureDevOpsArtifactsTests.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed.Tests/BuildModelFactoryTests.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/BuildModelFactory.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/BlobArtifactModelFactory.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/FileSystem.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/MSBuildTaskBase.cs Outdated
Comment thread src/Microsoft.DotNet.Build.Tasks.Feed/src/MSBuildTaskBase.cs Outdated
@missymessa missymessa merged commit 6261cf2 into master Dec 30, 2020
@missymessa missymessa deleted the missymessa-6344 branch January 5, 2021 19:02
akoeplinger pushed a commit to akoeplinger/arcade that referenced this pull request Apr 12, 2021
* oh boy we're doing some testing

* Set up fake filesystem, add test for PublishFlatContainer

* SigningInformation test

* remove net test sdk

* re-rename for merge

* Changes resulting from merge to master

* smoe more updates

* re-add generatebuildmanifest.proj

* quick fixups

* Some refactoring based on discussions of how to implement this better :)

* Got the abstract class in a good state; started refactoring classes so they can be dependency injected

* Tests work now

* Pulled Nunit stuff out of the test project since we're not using it

* missing namespaces were causing the build to fail

* Added more DI to the places that needed it. Fixed a couple of failing tests

* Injecting the TaskLoggingHelper into it's dependencies instead of manually passing it into methods

* Missed a couple places that needed the logger DI

* commenting all the things

* Tests to ensure DI was properly wired up for the refactored tasks

* Tests to ensure top-level dependencies are configured

* Fixing failing tests

* Attempting to fix Nuget error

* trying to suss out the nuget error

* trying to suss out the nuget error

* putting everything back the way it was

* checking to see if I can't reference the VersionTools.Task project for tests

* Let's see if this fixed the tests

* skip signing of testing project

* Omitting more test projects from being signed

* reverting changes to skip signing on test projects. Need a different solution

* Need to set up FluentAssertions to be signed by the third party cert

* Does Helix like strings that were once XDocuments better?

* Figure out why the task is failing on Helix

* Changed save options for ToString-ing XML to improve test reliability

* let's see if we can get error messages out of the Build Engine

* adding some logging to figure out why PackageArtifactModelFactory is failing

* Making the file path strings OS-agnostic

* Consolidated expected content builders into reusable functionality

* Created factory for VersionsRepoUpdater classes, attempting to abstract away some of the DI

* clean up random stuff that was added to the csproj files

Co-authored-by: Jon Fortescue <jofortes@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants