update the version of tasks.feed to latest produced by the 3.x branch#5809
Merged
riarenas merged 2 commits intodotnet:release/3.xfrom Jul 20, 2020
Merged
Conversation
…, also improve version management by taking the version from repo versions.props
2 tasks
mmitche
approved these changes
Jul 17, 2020
Contributor
Author
|
missed a place where the version was still hardcoded. New test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=736109&view=results |
markwilkie
approved these changes
Jul 17, 2020
Contributor
Author
|
Not sure what the Linux PR build failures are but they seem unrelated. Checking. |
Contributor
Author
😮 looks transient. retrying. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Test build finished successfully and published using the updated version of the tasks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the version of tasks.feed to latest produced by the 3.x branch, also improve version management by taking the version from repo versions.props
I'm validating the new task version in this build: https://dev.azure.com/dnceng/internal/_build/results?buildId=736053&view=results
Customer Impact
dotnet/interactive is seeing errors while publishing because the version of the task that the SDK uses still has the validation I removed in #5709
Regression
No.
Risk
Low. We removed this validation in the non-servicing branch a long time ago
Workarounds
None. If your publishing is blocked by the error this version removes, there's no recovery.